You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@chemistry.apache.org by sf...@apache.org on 2011/07/17 23:00:52 UTC
svn commit: r1147715 - in
/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck:
./ impl/ runner/ tests/basics/
Author: sfermigier
Date: Sun Jul 17 21:00:50 2011
New Revision: 1147715
URL: http://svn.apache.org/viewvc?rev=1147715&view=rev
Log:
Simplify.
Modified:
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTest.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/ConsoleRunner.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/WebRunnerServlet.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RepositoryInfoTest.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RootFolderTest.java
chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/SecurityTest.java
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java Sun Jul 17 21:00:50 2011
@@ -22,6 +22,7 @@ package org.apache.chemistry.opencmis.tc
* CMIS TCK Test Result Status.
*/
public enum CmisTestResultStatus {
+
INFO(0), // no check, just for reports
SKIPPED(1), // check has been skipped
OK(2), // check passed
@@ -31,7 +32,7 @@ public enum CmisTestResultStatus {
private final int level;
- private CmisTestResultStatus(int level) {
+ CmisTestResultStatus(int level) {
this.level = level;
}
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTest.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTest.java Sun Jul 17 21:00:50 2011
@@ -32,6 +32,7 @@ import org.junit.Test;
* Base class for tests.
*/
public abstract class AbstractCmisTest implements CmisTest {
+
private Map<String, String> parameters;
private AbstractCmisTestGroup group;
private String name;
@@ -145,11 +146,11 @@ public abstract class AbstractCmisTest i
// --- asserts ----
protected boolean isEqual(Object expected, Object actual) {
- if ((expected == null) && (actual == null)) {
+ if (expected == null && actual == null) {
return true;
}
- if ((expected != null) && expected.equals(actual)) {
+ if (expected != null && expected.equals(actual)) {
return true;
}
@@ -157,7 +158,7 @@ public abstract class AbstractCmisTest i
}
protected CmisTestResult assertIsTrue(Boolean test, CmisTestResult success, CmisTestResult failure) {
- if ((test != null) && (test.booleanValue())) {
+ if (test != null && test) {
return success;
}
@@ -169,7 +170,7 @@ public abstract class AbstractCmisTest i
}
protected CmisTestResult assertIsFalse(Boolean test, CmisTestResult success, CmisTestResult failure) {
- if ((test != null) && (!test.booleanValue())) {
+ if (test != null && !test) {
return success;
}
@@ -197,7 +198,7 @@ public abstract class AbstractCmisTest i
}
protected CmisTestResult assertStringNullOrEmpty(String str, CmisTestResult success, CmisTestResult failure) {
- if ((str == null) || (str.length() == 0)) {
+ if (str == null || str.length() == 0) {
return success;
}
@@ -205,7 +206,7 @@ public abstract class AbstractCmisTest i
}
protected CmisTestResult assertStringNotEmpty(String str, CmisTestResult success, CmisTestResult failure) {
- if ((str != null) && (str.length() > 0)) {
+ if (str != null && str.length() > 0) {
return success;
}
@@ -217,7 +218,7 @@ public abstract class AbstractCmisTest i
}
protected CmisTestResult assertListNotEmpty(List<?> list, CmisTestResult success, CmisTestResult failure) {
- if ((list != null) && (list.size() > 0)) {
+ if (list != null && list.size() > 0) {
return success;
}
@@ -253,7 +254,7 @@ public abstract class AbstractCmisTest i
protected CmisTestResult assertEqualLists(List<?> expected, List<?> actual, CmisTestResult success,
CmisTestResult failure) {
- if ((expected == null) && (actual == null)) {
+ if (expected == null && actual == null) {
return success;
}
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java Sun Jul 17 21:00:50 2011
@@ -31,6 +31,7 @@ import org.junit.Test;
* Base class for test groups.
*/
public abstract class AbstractCmisTestGroup implements CmisTestGroup {
+
private Map<String, String> parameters;
private String name;
private final List<CmisTest> tests = new ArrayList<CmisTest>();
@@ -83,7 +84,7 @@ public abstract class AbstractCmisTestGr
try {
preRun();
for (CmisTest test : tests) {
- if ((test == null) || (!test.isEnabled())) {
+ if (test == null || !test.isEnabled()) {
continue;
}
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java Sun Jul 17 21:00:50 2011
@@ -45,6 +45,7 @@ import org.apache.chemistry.opencmis.cli
import org.apache.chemistry.opencmis.client.runtime.SessionFactoryImpl;
import org.apache.chemistry.opencmis.commons.PropertyIds;
import org.apache.chemistry.opencmis.commons.SessionParameter;
+import org.apache.chemistry.opencmis.commons.data.AllowableActions;
import org.apache.chemistry.opencmis.commons.data.RepositoryCapabilities;
import org.apache.chemistry.opencmis.commons.data.RepositoryInfo;
import org.apache.chemistry.opencmis.commons.definitions.DocumentTypeDefinition;
@@ -151,14 +152,12 @@ public abstract class AbstractSessionTes
* Creates a folder.
*/
protected Folder createFolder(Folder parent, String name, String objectTypeId) {
- Folder result = null;
-
- CmisTestResult f;
Map<String, Object> properties = new HashMap<String, Object>();
properties.put(PropertyIds.NAME, name);
properties.put(PropertyIds.OBJECT_TYPE_ID, objectTypeId);
+ Folder result = null;
try {
// create the folder
result = parent.createFolder(properties);
@@ -181,7 +180,7 @@ public abstract class AbstractSessionTes
// check object parents
List<Folder> objectParents = result.getParents();
- f = createResult(FAILURE, "Newly created folder has no or more than one parent! Id: " + result.getId(),
+ CmisTestResult f = createResult(FAILURE, "Newly created folder has no or more than one parent! Id: " + result.getId(),
true);
addResult(assertEquals(1, objectParents.size(), null, f));
@@ -427,7 +426,7 @@ public abstract class AbstractSessionTes
Document doc = (Document) object;
if (doc.isVersionSeriesCheckedOut() != null) {
- if (doc.isVersionSeriesCheckedOut().booleanValue()) {
+ if (doc.isVersionSeriesCheckedOut()) {
f = createResult(WARNING, "Document is checked out and has CAN_CHECK_OUT allowable action!");
addResult(results, assertNotAllowableAction(object, Action.CAN_CHECK_OUT, null, f));
@@ -544,8 +543,9 @@ public abstract class AbstractSessionTes
protected CmisTestResult assertAllowableAction(CmisObject object, Action action, CmisTestResult success,
CmisTestResult failure) {
- if ((object.getAllowableActions() != null) && (object.getAllowableActions().getAllowableActions() != null)) {
- if (object.getAllowableActions().getAllowableActions().contains(action)) {
+ AllowableActions allowableActions = object.getAllowableActions();
+ if (allowableActions != null && allowableActions.getAllowableActions() != null) {
+ if (allowableActions.getAllowableActions().contains(action)) {
return success;
}
}
@@ -555,8 +555,9 @@ public abstract class AbstractSessionTes
protected CmisTestResult assertNotAllowableAction(CmisObject object, Action action, CmisTestResult success,
CmisTestResult failure) {
- if ((object.getAllowableActions() != null) && (object.getAllowableActions().getAllowableActions() != null)) {
- if (!object.getAllowableActions().getAllowableActions().contains(action)) {
+ AllowableActions allowableActions = object.getAllowableActions();
+ if (allowableActions != null && allowableActions.getAllowableActions() != null) {
+ if (!allowableActions.getAllowableActions().contains(action)) {
return success;
}
}
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java Sun Jul 17 21:00:50 2011
@@ -37,6 +37,7 @@ import org.apache.chemistry.opencmis.tck
* Base class for runners.
*/
public abstract class AbstractRunner {
+
public static final String OVERRIDE_KEY = "org.apache.chemistry";
public static final String DEFAULT_TCK_GROUPS = "/cmis-tck-groups.txt";
@@ -64,7 +65,7 @@ public abstract class AbstractRunner {
}
public void loadParameters(File file) throws Exception {
- if ((file == null) || (!file.isFile())) {
+ if (file == null || !file.isFile()) {
throw new IllegalArgumentException("File not found!");
}
@@ -85,7 +86,7 @@ public abstract class AbstractRunner {
String line;
while ((line = reader.readLine()) != null) {
line = line.trim();
- if (line.startsWith("#") || (line.length() == 0)) {
+ if (line.startsWith("#") || line.length() == 0) {
continue;
}
@@ -119,7 +120,7 @@ public abstract class AbstractRunner {
}
public void loadGroups(File file) throws Exception {
- if ((file == null) || (!file.isFile())) {
+ if (file == null || !file.isFile()) {
throw new IllegalArgumentException("File not found!");
}
@@ -139,7 +140,7 @@ public abstract class AbstractRunner {
String line;
while ((line = reader.readLine()) != null) {
line = line.trim();
- if (line.startsWith("#") || (line.length() == 0)) {
+ if (line.startsWith("#") || line.length() == 0) {
continue;
}
@@ -216,7 +217,7 @@ public abstract class AbstractRunner {
}
}
- if ((group == null) || (!group.isEnabled())) {
+ if (group == null || !group.isEnabled()) {
continue;
}
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java Sun Jul 17 21:00:50 2011
@@ -34,6 +34,7 @@ import org.apache.tools.ant.Task;
* CMIS TCK Ant Task.
*/
public class CmisTckAntTask extends Task {
+
private static final String REPORT_TEXT = "text";
private static final String REPORT_XML = "xml";
private static final String REPORT_HTML = "html";
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/ConsoleRunner.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/ConsoleRunner.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/ConsoleRunner.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/ConsoleRunner.java Sun Jul 17 21:00:50 2011
@@ -34,6 +34,7 @@ import org.apache.chemistry.opencmis.tck
* Session parameters file name and group list file name.
*/
public class ConsoleRunner extends AbstractRunner {
+
public ConsoleRunner(String[] args) throws Exception {
if (args.length < 1) {
setParameters(null);
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/WebRunnerServlet.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/WebRunnerServlet.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/WebRunnerServlet.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/WebRunnerServlet.java Sun Jul 17 21:00:50 2011
@@ -126,7 +126,7 @@ public class WebRunnerServlet extends Ht
}
private static class WebProgressMonitor implements CmisTestProgressMonitor {
- private PrintWriter pw;
+ private final PrintWriter pw;
public WebProgressMonitor(PrintWriter pw) {
this.pw = pw;
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RepositoryInfoTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RepositoryInfoTest.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RepositoryInfoTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RepositoryInfoTest.java Sun Jul 17 21:00:50 2011
@@ -36,6 +36,7 @@ import org.apache.chemistry.opencmis.tck
* Repository info test.
*/
public class RepositoryInfoTest extends AbstractSessionTest {
+
@Override
public void init(Map<String, String> parameters) {
super.init(parameters);
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RootFolderTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RootFolderTest.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RootFolderTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/RootFolderTest.java Sun Jul 17 21:00:50 2011
@@ -36,6 +36,7 @@ import org.apache.chemistry.opencmis.tck
* Basic root folder tests.
*/
public class RootFolderTest extends AbstractSessionTest {
+
@Override
public void init(Map<String, String> parameters) {
super.init(parameters);
Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/SecurityTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/SecurityTest.java?rev=1147715&r1=1147714&r2=1147715&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/SecurityTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/tests/basics/SecurityTest.java Sun Jul 17 21:00:50 2011
@@ -29,6 +29,7 @@ import org.apache.chemistry.opencmis.tck
import org.apache.chemistry.opencmis.tck.impl.AbstractSessionTest;
public class SecurityTest extends AbstractSessionTest {
+
@Override
public void init(Map<String, String> parameters) {
super.init(parameters);
@@ -43,7 +44,7 @@ public class SecurityTest extends Abstra
addResult(createInfoResult("Binding: " + binding));
- f = createResult(WARNING, "HTTPS is not used. Credentials might be transfered as plain text!");
+ f = createResult(WARNING, "HTTPS is not used. Credentials might be transferred as plain text!");
switch (binding) {
case ATOMPUB:
Re: svn commit: r1147715 - in /chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck: ./ impl/ runner/ tests/basics/
Posted by Stefane Fermigier <sf...@nuxeo.com>.
On Jul 18, 2011, at 5:35 PM, Florent Guillaume wrote:
> Please don't do this.
> The code as you wrote it uses implicit unboxing, which Eclipse warns
> about (rightfully as it can cause lots of NPE (although not in this
> particular case)).
The NPE can't happen because of the nullity test. If Eclipse complains, it is pretty stupid about it ;)
> The original code was fine, although I'd rather it be written as:
> if (Boolean.FALSE.equals(test))
Indeed, the intention is clearer this way.
Or, even clearer:
if (FALSE.equals(test))
with a static import of Boolean.FALSE.
S.
>
> Florent
>
> On Sun, Jul 17, 2011 at 11:00 PM, <sf...@apache.org> wrote:
>> Author: sfermigier
>> Date: Sun Jul 17 21:00:50 2011
>> New Revision: 1147715
>>
>> URL: http://svn.apache.org/viewvc?rev=1147715&view=rev
>> Log:
>> Simplify.
>>
>> protected CmisTestResult assertIsFalse(Boolean test, CmisTestResult success, CmisTestResult failure) {
>> - if ((test != null) && (!test.booleanValue())) {
>> + if (test != null && !test) {
>> return success;
>> }
>>
>
>
> --
> Florent Guillaume, Director of R&D, Nuxeo
> Open Source, Java EE based, Enterprise Content Management (ECM)
> http://www.nuxeo.com http://www.nuxeo.org +33 1 40 33 79 87
--
Stefane Fermigier, Founder and Chairman, Nuxeo
Open Source, Java EE based, Enterprise Content Management (ECM)
http://www.nuxeo.com/ - +33 1 40 33 79 87 - http://twitter.com/sfermigier
Join the Nuxeo Group on LinkedIn: http://linkedin.com/groups?gid=43314
New Nuxeo release: http://nuxeo.com/dm54
"There's no such thing as can't. You always have a choice."
Re: svn commit: r1147715 - in /chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck:
./ impl/ runner/ tests/basics/
Posted by Florent Guillaume <fg...@nuxeo.com>.
Please don't do this.
The code as you wrote it uses implicit unboxing, which Eclipse warns
about (rightfully as it can cause lots of NPE (although not in this
particular case)).
The original code was fine, although I'd rather it be written as:
if (Boolean.FALSE.equals(test))
Florent
On Sun, Jul 17, 2011 at 11:00 PM, <sf...@apache.org> wrote:
> Author: sfermigier
> Date: Sun Jul 17 21:00:50 2011
> New Revision: 1147715
>
> URL: http://svn.apache.org/viewvc?rev=1147715&view=rev
> Log:
> Simplify.
>
> protected CmisTestResult assertIsFalse(Boolean test, CmisTestResult success, CmisTestResult failure) {
> - if ((test != null) && (!test.booleanValue())) {
> + if (test != null && !test) {
> return success;
> }
>
--
Florent Guillaume, Director of R&D, Nuxeo
Open Source, Java EE based, Enterprise Content Management (ECM)
http://www.nuxeo.com http://www.nuxeo.org +33 1 40 33 79 87