You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/13 11:09:43 UTC
Review Request 39263: Windows:[2/3] transitioned libprocess to use
`os::raw::` family.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39263/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
The last commit in this chain introduces a family of environment wrapper
methods in the `os::raw` namespace. This commit will transition the
process library to use these functions.
Diffs
-----
3rdparty/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d
Diff: https://reviews.apache.org/r/39263/diff/
Testing
-------
`make check` on Ubuntu 15, OS X 10.10, and running the `check` project on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39263: Windows:[2/3] transitioned libprocess to use
`os::raw::` family.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39263/#review102528
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 13, 2015, 11:36 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39263/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 11:36 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The last commit in this chain introduces a family of environment wrapper
> methods in the `os::raw` namespace. This commit will transition the
> process library to use these functions.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d
>
> Diff: https://reviews.apache.org/r/39263/diff/
>
>
> Testing
> -------
>
> `make check` on Ubuntu 15, OS X 10.10, and running the `check` project on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39263: Windows:[2/3] transitioned libprocess to use
`os::raw::` family.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39263/#review103065
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Oct. 13, 2015, 6:36 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39263/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 6:36 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The last commit in this chain introduces a family of environment wrapper
> methods in the `os::raw` namespace. This commit will transition the
> process library to use these functions.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d
>
> Diff: https://reviews.apache.org/r/39263/diff/
>
>
> Testing
> -------
>
> `make check` on Ubuntu 15, OS X 10.10, and running the `check` project on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39263: Windows:[2/3] transitioned libprocess to use
`os::raw::` family.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39263/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 6:36 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
The last commit in this chain introduces a family of environment wrapper
methods in the `os::raw` namespace. This commit will transition the
process library to use these functions.
Diffs (updated)
-----
3rdparty/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d
Diff: https://reviews.apache.org/r/39263/diff/
Testing
-------
`make check` on Ubuntu 15, OS X 10.10, and running the `check` project on Windows 10.
Thanks,
Alex Clemmer