You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/03/12 16:54:50 UTC
Review Request 31990: Added initial readability code review/comments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31990/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Ben Mahler.
Repository: mesos
Description
-------
The plan is to have a collection of code snippets that capture our unique style so that new committers can do "review exercises" to practice and perfect their readability requirements. This is just the beginning, we plan on creating a lot more of these.
Diffs
-----
readability/naming_comments.cpp PRE-CREATION
readability/naming_review.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31990/diff/
Testing
-------
None yet, Bernd is going to handle this for me! Thanks Bernd. ;-)
Thanks,
Benjamin Hindman
Re: Review Request 31990: Added initial readability code
review/comments.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31990/#review76262
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31990]
All tests passed.
- Mesos ReviewBot
On March 12, 2015, 3:54 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31990/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 3:54 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The plan is to have a collection of code snippets that capture our unique style so that new committers can do "review exercises" to practice and perfect their readability requirements. This is just the beginning, we plan on creating a lot more of these.
>
>
> Diffs
> -----
>
> readability/naming_comments.cpp PRE-CREATION
> readability/naming_review.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31990/diff/
>
>
> Testing
> -------
>
> None yet, Bernd is going to handle this for me! Thanks Bernd. ;-)
>
>
> Thanks,
>
> Benjamin Hindman
>
>