You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Brandon Fuller (JIRA)" <ji...@apache.org> on 2010/09/17 00:30:33 UTC

[jira] Created: (WICKET-3054) PropertyResolver$MapGetSet Broken When Integer Used As Key

PropertyResolver$MapGetSet Broken When Integer Used As Key
----------------------------------------------------------

                 Key: WICKET-3054
                 URL: https://issues.apache.org/jira/browse/WICKET-3054
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.8
         Environment: Java 1.6
            Reporter: Brandon Fuller
            Priority: Minor


The class stores the key internally as a string.  This causes issues if anything other than a string is actually the key for the map.  The get() routine fails because of the object.equals of the different class.

My code was not working with an integer-based key.  Converted it to a string and the same code now works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (WICKET-3054) PropertyResolver$MapGetSet Broken When Integer Used As Key

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/WICKET-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson closed WICKET-3054.
------------------------------------

      Assignee: Jeremy Thomerson
    Resolution: Won't Fix

According to the javadocs, this is correct behavior.  Quoting: "Or if a map is given as an object it will be lookup with the property as a key when there is not get method for that property."  

I don't think we should "fix" this because there are too many possible combinations.... what if your map has a Boolean key?  Or a Double key?  We have no way to know what kind of keys to try.  The property expression can only be a string, so it makes sense to limit ourselves to string keys.

> PropertyResolver$MapGetSet Broken When Integer Used As Key
> ----------------------------------------------------------
>
>                 Key: WICKET-3054
>                 URL: https://issues.apache.org/jira/browse/WICKET-3054
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.8
>         Environment: Java 1.6
>            Reporter: Brandon Fuller
>            Assignee: Jeremy Thomerson
>            Priority: Minor
>
> The class stores the key internally as a string.  This causes issues if anything other than a string is actually the key for the map.  The get() routine fails because of the object.equals of the different class.
> My code was not working with an integer-based key.  Converted it to a string and the same code now works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.