You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sandhyasun <gi...@git.apache.org> on 2018/01/03 18:33:30 UTC
[GitHub] trafodion pull request #1365: TRAFODION-2873. Cleanup of LobGlobals and LobL...
GitHub user sandhyasun opened a pull request:
https://github.com/apache/trafodion/pull/1365
TRAFODION-2873. Cleanup of LobGlobals and LobLoad classes
This fix also avoids a core that was very occasionally caused during inserts into LOB tables. The fix involves cleaning up the LOBGlibals and eliminating unneeded datamemebers and keeping only the ExLobGlobals members. Also cleaned up all LobLoad related code since it is obsolete and worked only with DP2.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandhyasun/trafodion traf_lob_global_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1365.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1365
----
commit 701b2799884a402850d3e082cd717cbc5065c2c0
Author: Sandhya Sundaresan <sa...@...>
Date: 2018-01-03T18:30:04Z
TRAFODION-2873. Fix for avoiding cores during expression eval for inserts into LOB tables. The fix involves cleaning up the LOBGlibals and eliminating unneeded datamemebers and keeping only the ExLobGlobals members. Also cleaned up all LobLoad related code since it is obsolete and worked only with DP2.
Conflicts:
core/sql/executor/ExExeUtilLoad.cpp
----
---
[GitHub] trafodion pull request #1365: TRAFODION-2873. Cleanup of LobGlobals and LobL...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1365#discussion_r159528878
--- Diff: core/sql/exp/exp_clause.cpp ---
@@ -574,8 +574,8 @@ ex_clause::ex_clause(clause_type type,
case ITM_LOBCONVERTHANDLE:
setClassID(LOB_CONVERTHANDLE);
break;
- case ITM_LOBLOAD:
- setClassID(LOB_LOAD);
+ /* case ITM_LOBLOAD:
--- End diff --
Maybe delete these lines (and the break after them) instead of commenting out?
---
[GitHub] trafodion pull request #1365: TRAFODION-2873. Cleanup of LobGlobals and LobL...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1365
---