You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/23 12:44:13 UTC

[GitHub] [solr] asalamon74 opened a new pull request #44: SOLR-15280 Misleading error message in HdfsDirectoryFactory

asalamon74 opened a new pull request #44:
URL: https://github.com/apache/solr/pull/44


   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-####: <short description of problem or changes>
   
   SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   Misleading error message in HdfsDirectoryFactory
   
   # Solution
   
   Fixing the error message.
   
   # Tests
   
   Unit tests
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] madrob merged pull request #44: SOLR-15280 Misleading error message in HdfsDirectoryFactory

Posted by GitBox <gi...@apache.org>.
madrob merged pull request #44:
URL: https://github.com/apache/solr/pull/44


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] asalamon74 commented on pull request #44: SOLR-15280 Misleading error message in HdfsDirectoryFactory

Posted by GitBox <gi...@apache.org>.
asalamon74 commented on pull request #44:
URL: https://github.com/apache/solr/pull/44#issuecomment-848690442


   Thanks for picking this up @madrob 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] madrob commented on pull request #44: SOLR-15280 Misleading error message in HdfsDirectoryFactory

Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #44:
URL: https://github.com/apache/solr/pull/44#issuecomment-842541586


   @janhoy do you want to merge? If not, I'll update the changes entry and merge it later this week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] asalamon74 commented on pull request #44: SOLR-15280 Misleading error message in HdfsDirectoryFactory

Posted by GitBox <gi...@apache.org>.
asalamon74 commented on pull request #44:
URL: https://github.com/apache/solr/pull/44#issuecomment-830044254


   Solved the conflict caused by SOLR-15329. @janhoy can you please check it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] janhoy commented on pull request #44: SOLR-15280 Misleading error message in HdfsDirectoryFactory

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #44:
URL: https://github.com/apache/solr/pull/44#issuecomment-805788676


   If you want credit in CHANGES.txt then please add a line to the 9.0 section of that file
   
       SOLR-15280 Fixed misleading error message in HdfsDirectoryFactory (András Salamon via janhoy)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org