You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/19 10:14:15 UTC

[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #4850: #4460, fix order by string column exception

tuohai666 opened a new pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850
 
 
   Fixes #4460.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 2171](https://coveralls.io/builds/29476177)
   
   * **22** of **49**   **(44.9%)**  changed or added relevant lines in **5** files are covered.
   * **9** unchanged lines in **4** files lost coverage.
   * Overall coverage increased (+**0.02%**) to **59.662%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29476177/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java](https://coveralls.io/builds/29476177/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Forderby%2FOrderByValue.java#L71) | 14 | 22 | 63.64%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29476177/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L63) | 0 | 18 | 0.0%
   <!-- | **Total:** | **22** | **49** | **44.9%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29476177/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L68) | 1 | 0% |
   | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/29476177/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29476177/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L119) | 3 | 0% |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29476177/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L86) | 4 | 62.5% |
   <!-- | **Total:** | **9** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29476177/badge)](https://coveralls.io/builds/29476177) |
   | :-- | --: |
   | Change from base [Build 1120](https://coveralls.io/builds/29467416): |  0.02% |
   | Covered Lines: | 12489 |
   | Relevant Lines: | 20933 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

tuohai666 commented on a change in pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r395488646
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaData.java
 ##########
 @@ -36,4 +37,7 @@
     private final String dataType;
     
     private final boolean primaryKey;
+    
+    @Setter
+    private boolean isCaseSensitive;
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 10415](https://coveralls.io/builds/29476146)
   
   * **22** of **49**   **(44.9%)**  changed or added relevant lines in **5** files are covered.
   * **12** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.06%**) to **59.585%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29476146/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java](https://coveralls.io/builds/29476146/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Forderby%2FOrderByValue.java#L71) | 14 | 22 | 63.64%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29476146/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L63) | 0 | 18 | 0.0%
   <!-- | **Total:** | **22** | **49** | **44.9%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29476146/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L68) | 1 | 0% |
   | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/29476146/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29476146/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L119) | 3 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29476146/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29476146/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L86) | 4 | 62.5% |
   <!-- | **Total:** | **12** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29476146/badge)](https://coveralls.io/builds/29476146) |
   | :-- | --: |
   | Change from base [Build 1120](https://coveralls.io/builds/29467416): |  -0.06% |
   | Covered Lines: | 12473 |
   | Relevant Lines: | 20933 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601545150
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=h1) Report
   > Merging [#4850](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6f9294f0afea087673dbbc6d96b7894e086ba26f&el=desc) will **decrease** coverage by `1.15%`.
   > The diff coverage is `46.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4850      +/-   ##
   ============================================
   - Coverage     56.19%   55.04%   -1.16%     
   + Complexity      448      436      -12     
   ============================================
     Files          1163     1136      -27     
     Lines         20895    20344     -551     
     Branches       3880     3760     -120     
   ============================================
   - Hits          11742    11198     -544     
   - Misses         8424     8437      +13     
   + Partials        729      709      -20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sphere/encrypt/metadata/EncryptColumnMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdENvbHVtbk1ldGFEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../execute/sql/execute/result/MemoryQueryResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWV4ZWN1dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2V4ZWN1dGUvc3FsL2V4ZWN1dGUvcmVzdWx0L01lbW9yeVF1ZXJ5UmVzdWx0LmphdmE=) | `96.07% <50.00%> (-1.97%)` | `0.00 <0.00> (ø)` | |
   | [.../execute/sql/execute/result/StreamQueryResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWV4ZWN1dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2V4ZWN1dGUvc3FsL2V4ZWN1dGUvcmVzdWx0L1N0cmVhbVF1ZXJ5UmVzdWx0LmphdmE=) | `92.30% <50.00%> (-1.93%)` | `0.00 <0.00> (ø)` | |
   | [...phere/sharding/merge/dql/orderby/OrderByValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvb3JkZXJieS9PcmRlckJ5VmFsdWUuamF2YQ==) | `83.67% <72.72%> (-9.88%)` | `0.00 <0.00> (ø)` | |
   | [...re/sharding/merge/dql/ShardingDQLResultMerger.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvU2hhcmRpbmdEUUxSZXN1bHRNZXJnZXIuamF2YQ==) | `69.23% <75.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/merge/dql/groupby/GroupByMemoryMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvZ3JvdXBieS9Hcm91cEJ5TWVtb3J5TWVyZ2VkUmVzdWx0LmphdmE=) | `93.10% <75.00%> (-2.82%)` | `1.00 <1.00> (ø)` | |
   | [...g/merge/dql/groupby/GroupByStreamMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvZ3JvdXBieS9Hcm91cEJ5U3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `94.11% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/merge/dql/orderby/OrderByStreamMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvb3JkZXJieS9PcmRlckJ5U3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...lying/common/config/TypeBasedSPIConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9UeXBlQmFzZWRTUElDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [112 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=footer). Last update [6f9294f...b8bdad7](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

terrymanu commented on a change in pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r395422844
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaData.java
 ##########
 @@ -36,4 +37,7 @@
     private final String dataType;
     
     private final boolean primaryKey;
+    
+    @Setter
+    private boolean isCaseSensitive;
 
 Review comment:
   Please do not use setter, we may keep consist with other fields.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 2184](https://coveralls.io/builds/29494069)
   
   * **38** of **66**   **(57.58%)**  changed or added relevant lines in **8** files are covered.
   * **22** unchanged lines in **6** files lost coverage.
   * Overall coverage decreased (**-0.03%**) to **59.615%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29494069/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29494069/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29494069/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/groupby/GroupByMemoryMergedResult.java](https://coveralls.io/builds/29494069/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Fgroupby%2FGroupByMemoryMergedResult.java#L132) | 11 | 12 | 91.67%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java](https://coveralls.io/builds/29494069/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Forderby%2FOrderByValue.java#L71) | 17 | 23 | 73.91%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29494069/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L63) | 0 | 18 | 0.0%
   <!-- | **Total:** | **38** | **66** | **57.58%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29494069/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L68) | 1 | 0% |
   | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/29494069/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29494069/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L119) | 3 | 0% |
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouter.java](https://coveralls.io/builds/29494069/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouter.java#L166) | 4 | 34.48% |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29494069/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L86) | 4 | 62.5% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29494069/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L108) | 9 | 1.54% |
   <!-- | **Total:** | **22** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29494069/badge)](https://coveralls.io/builds/29494069) |
   | :-- | --: |
   | Change from base [Build 1120](https://coveralls.io/builds/29467416): |  -0.03% |
   | Covered Lines: | 12465 |
   | Relevant Lines: | 20909 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 10488](https://coveralls.io/builds/29541291)
   
   * **44** of **103**   **(42.72%)**  changed or added relevant lines in **23** files are covered.
   * **5** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.06%**) to **58.114%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptColumnMetaData.java](https://coveralls.io/builds/29541291/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptColumnMetaData.java#L41) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java](https://coveralls.io/builds/29541291/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingTableMetaDataDecorator.java#L53) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29541291/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29541291/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29541291/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/groupby/GroupByMemoryMergedResult.java](https://coveralls.io/builds/29541291/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Fgroupby%2FGroupByMemoryMergedResult.java#L132) | 11 | 12 | 91.67%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/MasterSlaveSchema.java](https://coveralls.io/builds/29541291/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FMasterSlaveSchema.java#L79) | 0 | 1 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShadowSchema.java](https://coveralls.io/builds/29541291/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShadowSchema.java#L71) | 0 | 1 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/TransparentSchema.java](https://coveralls.io/builds/29541291/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FTransparentSchema.java#L63) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaDataLoader.java](https://coveralls.io/builds/29541291/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaDataLoader.java#L46) | 0 | 1 | 0.0%
   <!-- | **Total:** | **44** | **103** | **42.72%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29541291/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L98) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29541291/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L79) | 1 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29541291/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **5** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29541291/badge)](https://coveralls.io/builds/29541291) |
   | :-- | --: |
   | Change from base [Build 1143](https://coveralls.io/builds/29530464): |  -0.06% |
   | Covered Lines: | 11889 |
   | Relevant Lines: | 20458 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

terrymanu commented on a change in pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r395422211
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java
 ##########
 @@ -60,9 +60,34 @@
                 result.add(new ColumnMetaData(columnName, columnType, isPrimaryKey));
             }
         }
+        try (ResultSet resultSet = connection.createStatement().executeQuery(generateEmptyResultSQL(connection, table))) {
+            for (ColumnMetaData each : result) {
+                each.setCaseSensitive(resultSet.getMetaData().isCaseSensitive(resultSet.findColumn(each.getName())));
+            }
+        }
         return result;
     }
     
+    private static String generateEmptyResultSQL(final Connection connection, final String table) throws SQLException {
+        String delimiterLeft;
+        String delimiterRight;
+        String url = connection.getMetaData().getURL();
+        if (url.startsWith("jdbc:mysql:")) {
+            delimiterLeft = "`";
+            delimiterRight = "`";
+        } else if (url.startsWith("jdbc:oracle:") || url.startsWith("jdbc:postgresql:") || url.startsWith("jdbc:h2:")) {
+            delimiterLeft = "\"";
+            delimiterRight = "\"";
+        } else if (url.startsWith("jdbc:sqlserver:")) {
+            delimiterLeft = "[";
+            delimiterRight = "]";
+        } else {
+            delimiterLeft = "";
+            delimiterRight = "";
+        }
+        return "SELECT * FROM " + delimiterLeft + table + delimiterRight + " WHERE 1 != 1;";
 
 Review comment:
   Please re-design about the codes here.
   We should never do something about the sql dialect in this module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601545150
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=h1) Report
   > Merging [#4850](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6f9294f0afea087673dbbc6d96b7894e086ba26f?src=pr&el=desc) will **decrease** coverage by `0.21%`.
   > The diff coverage is `44.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4850      +/-   ##
   ============================================
   - Coverage     56.19%   55.98%   -0.22%     
   - Complexity      448      449       +1     
   ============================================
     Files          1163     1166       +3     
     Lines         20895    20902       +7     
     Branches       3880     3892      +12     
   ============================================
   - Hits          11742    11701      -41     
   - Misses         8424     8471      +47     
   - Partials        729      730       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../execute/sql/execute/result/MemoryQueryResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWV4ZWN1dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2V4ZWN1dGUvc3FsL2V4ZWN1dGUvcmVzdWx0L01lbW9yeVF1ZXJ5UmVzdWx0LmphdmE=) | `96.15% <0%> (-1.89%)` | `0 <0> (ø)` | |
   | [.../execute/sql/execute/result/StreamQueryResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWV4ZWN1dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2V4ZWN1dGUvc3FsL2V4ZWN1dGUvcmVzdWx0L1N0cmVhbVF1ZXJ5UmVzdWx0LmphdmE=) | `92.45% <0%> (-1.78%)` | `0 <0> (ø)` | |
   | [...g/merge/dql/orderby/OrderByStreamMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvb3JkZXJieS9PcmRlckJ5U3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/merge/dql/groupby/GroupByStreamMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvZ3JvdXBieS9Hcm91cEJ5U3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `94.11% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...phere/sharding/merge/dql/orderby/OrderByValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvb3JkZXJieS9PcmRlckJ5VmFsdWUuamF2YQ==) | `80% <65.21%> (-13.55%)` | `0 <0> (ø)` | |
   | [...re/sharding/merge/dql/ShardingDQLResultMerger.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvU2hhcmRpbmdEUUxSZXN1bHRNZXJnZXIuamF2YQ==) | `69.23% <75%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...lying/common/config/TypeBasedSPIConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9UeXBlQmFzZWRTUElDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (-85.72%)` | `0% <0%> (ø)` | |
   | [.../command/query/text/query/MySQLComQueryPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvcXVlcnkvTXlTUUxDb21RdWVyeVBhY2tldC5qYXZh) | `62.5% <0%> (-37.5%)` | `0% <0%> (ø)` | |
   | [...nlog/row/column/value/time/MySQLTimeValueUtil.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS90aW1lL015U1FMVGltZVZhbHVlVXRpbC5qYXZh) | `66.66% <0%> (-16.67%)` | `0% <0%> (ø)` | |
   | ... and [73 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=footer). Last update [6f9294f...79a8c00](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

tuohai666 commented on a change in pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r396229840
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java
 ##########
 @@ -60,9 +60,34 @@
                 result.add(new ColumnMetaData(columnName, columnType, isPrimaryKey));
             }
         }
+        try (ResultSet resultSet = connection.createStatement().executeQuery(generateEmptyResultSQL(connection, table))) {
+            for (ColumnMetaData each : result) {
+                each.setCaseSensitive(resultSet.getMetaData().isCaseSensitive(resultSet.findColumn(each.getName())));
+            }
+        }
         return result;
     }
     
+    private static String generateEmptyResultSQL(final Connection connection, final String table) throws SQLException {
+        String delimiterLeft;
+        String delimiterRight;
+        String url = connection.getMetaData().getURL();
+        if (url.startsWith("jdbc:mysql:")) {
+            delimiterLeft = "`";
+            delimiterRight = "`";
+        } else if (url.startsWith("jdbc:oracle:") || url.startsWith("jdbc:postgresql:") || url.startsWith("jdbc:h2:")) {
+            delimiterLeft = "\"";
+            delimiterRight = "\"";
+        } else if (url.startsWith("jdbc:sqlserver:")) {
+            delimiterLeft = "[";
+            delimiterRight = "]";
+        } else {
+            delimiterLeft = "";
+            delimiterRight = "";
+        }
+        return "SELECT * FROM " + delimiterLeft + table + delimiterRight + " WHERE 1 != 1;";
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

terrymanu merged pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

tuohai666 commented on a change in pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r395489059
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaData.java
 ##########
 @@ -36,4 +37,7 @@
     private final String dataType;
     
     private final boolean primaryKey;
+    
+    @Setter
+    private boolean isCaseSensitive;
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 10492](https://coveralls.io/builds/29542081)
   
   * **44** of **103**   **(42.72%)**  changed or added relevant lines in **23** files are covered.
   * **33** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.06%**) to **58.112%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptColumnMetaData.java](https://coveralls.io/builds/29542081/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptColumnMetaData.java#L41) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java](https://coveralls.io/builds/29542081/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingTableMetaDataDecorator.java#L53) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29542081/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29542081/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29542081/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/groupby/GroupByMemoryMergedResult.java](https://coveralls.io/builds/29542081/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Fgroupby%2FGroupByMemoryMergedResult.java#L132) | 11 | 12 | 91.67%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/MasterSlaveSchema.java](https://coveralls.io/builds/29542081/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FMasterSlaveSchema.java#L79) | 0 | 1 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShadowSchema.java](https://coveralls.io/builds/29542081/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShadowSchema.java#L71) | 0 | 1 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/TransparentSchema.java](https://coveralls.io/builds/29542081/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FTransparentSchema.java#L63) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaDataLoader.java](https://coveralls.io/builds/29542081/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaDataLoader.java#L46) | 0 | 1 | 0.0%
   <!-- | **Total:** | **44** | **103** | **42.72%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29542081/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L98) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29542081/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L79) | 1 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29542081/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java](https://coveralls.io/builds/29542081/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FCuratorZookeeperCenterRepository.java#L93) | 28 | 72.07% |
   <!-- | **Total:** | **33** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29542081/badge)](https://coveralls.io/builds/29542081) |
   | :-- | --: |
   | Change from base [Build 1143](https://coveralls.io/builds/29530464): |  -0.06% |
   | Covered Lines: | 11885 |
   | Relevant Lines: | 20452 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 2180](https://coveralls.io/builds/29492766)
   
   * **25** of **52**   **(48.08%)**  changed or added relevant lines in **7** files are covered.
   * **22** unchanged lines in **6** files lost coverage.
   * Overall coverage decreased (**-0.03%**) to **59.607%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29492766/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29492766/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29492766/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java](https://coveralls.io/builds/29492766/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Forderby%2FOrderByValue.java#L71) | 17 | 23 | 73.91%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29492766/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L63) | 0 | 18 | 0.0%
   <!-- | **Total:** | **25** | **52** | **48.08%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29492766/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L68) | 1 | 0% |
   | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/29492766/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29492766/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L119) | 3 | 0% |
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouter.java](https://coveralls.io/builds/29492766/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouter.java#L166) | 4 | 34.48% |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29492766/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L86) | 4 | 62.5% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29492766/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L108) | 9 | 1.54% |
   <!-- | **Total:** | **22** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29492766/badge)](https://coveralls.io/builds/29492766) |
   | :-- | --: |
   | Change from base [Build 1120](https://coveralls.io/builds/29467416): |  -0.03% |
   | Covered Lines: | 12459 |
   | Relevant Lines: | 20902 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 2216](https://coveralls.io/builds/29542123)
   
   * **44** of **103**   **(42.72%)**  changed or added relevant lines in **23** files are covered.
   * **30** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.02%**) to **58.19%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptColumnMetaData.java](https://coveralls.io/builds/29542123/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptColumnMetaData.java#L41) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java](https://coveralls.io/builds/29542123/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingTableMetaDataDecorator.java#L53) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29542123/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29542123/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29542123/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/groupby/GroupByMemoryMergedResult.java](https://coveralls.io/builds/29542123/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Fgroupby%2FGroupByMemoryMergedResult.java#L132) | 11 | 12 | 91.67%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/MasterSlaveSchema.java](https://coveralls.io/builds/29542123/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FMasterSlaveSchema.java#L79) | 0 | 1 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShadowSchema.java](https://coveralls.io/builds/29542123/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShadowSchema.java#L71) | 0 | 1 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/TransparentSchema.java](https://coveralls.io/builds/29542123/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FTransparentSchema.java#L63) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaDataLoader.java](https://coveralls.io/builds/29542123/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaDataLoader.java#L46) | 0 | 1 | 0.0%
   <!-- | **Total:** | **44** | **103** | **42.72%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29542123/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L98) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29542123/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L79) | 1 | 0% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java](https://coveralls.io/builds/29542123/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FCuratorZookeeperCenterRepository.java#L93) | 28 | 72.07% |
   <!-- | **Total:** | **30** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29542123/badge)](https://coveralls.io/builds/29542123) |
   | :-- | --: |
   | Change from base [Build 1143](https://coveralls.io/builds/29530464): |  0.02% |
   | Covered Lines: | 11901 |
   | Relevant Lines: | 20452 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

terrymanu commented on a change in pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r395421837
 
 

 ##########
 File path: sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java
 ##########
 @@ -43,17 +52,38 @@
     
     private List<Comparable<?>> orderValues;
     
-    public OrderByValue(final QueryResult queryResult, final Collection<OrderByItem> orderByItems) {
+    public OrderByValue(final QueryResult queryResult, final Collection<OrderByItem> orderByItems, final SelectStatementContext selectStatementContext, final SchemaMetaData schemaMetaData) {
         this.queryResult = queryResult;
         this.orderByItems = orderByItems;
-        this.orderValuesCaseSensitive = getOrderValuesCaseSensitive();
+        this.orderValuesCaseSensitive = getOrderValuesCaseSensitive(selectStatementContext, schemaMetaData);
     }
     
     @SneakyThrows
-    private List<Boolean> getOrderValuesCaseSensitive() {
+    private List<Boolean> getOrderValuesCaseSensitive(final SelectStatementContext selectStatementContext, final SchemaMetaData schemaMetaData) {
         List<Boolean> result = new ArrayList<>(orderByItems.size());
-        for (OrderByItem each : orderByItems) {
-            result.add(queryResult.isCaseSensitive(each.getIndex()));
+        for (OrderByItem eachOrderByItem : orderByItems) {
+            for (SimpleTableSegment eachSimpleTableSegment : selectStatementContext.getAllTables()) {
+                String tableName = eachSimpleTableSegment.getTableName().getIdentifier().getValue();
+                TableMetaData tableMetaData = schemaMetaData.get(tableName);
+                Map<String, ColumnMetaData> columns = tableMetaData.getColumns();
+                OrderByItemSegment orderByItemSegment = eachOrderByItem.getSegment();
+                if (orderByItemSegment instanceof ColumnOrderByItemSegment) {
+                    String columnName = ((ColumnOrderByItemSegment) orderByItemSegment).getColumn().getIdentifier().getValue();
+                    if (columns.containsKey(columnName)) {
+                        result.add(columns.get(columnName).isCaseSensitive());
+                        break;
+                    }
+                } else if (orderByItemSegment instanceof IndexOrderByItemSegment) {
+                    int columnIndex = ((IndexOrderByItemSegment) orderByItemSegment).getColumnIndex();
+                    if (columns.values().toArray().length >= columnIndex) {
+                        result.add(((ColumnMetaData) columns.values().toArray()[columnIndex - 1]).isCaseSensitive());
+                        break;
+                    }
+                } else {
+                    result.add(false);
+                    break;
 
 Review comment:
   This method are pretty long, and lots of break in this method. Can you consider about extract them as serval small methods?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

tuohai666 commented on a change in pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r395488502
 
 

 ##########
 File path: sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java
 ##########
 @@ -43,17 +52,38 @@
     
     private List<Comparable<?>> orderValues;
     
-    public OrderByValue(final QueryResult queryResult, final Collection<OrderByItem> orderByItems) {
+    public OrderByValue(final QueryResult queryResult, final Collection<OrderByItem> orderByItems, final SelectStatementContext selectStatementContext, final SchemaMetaData schemaMetaData) {
         this.queryResult = queryResult;
         this.orderByItems = orderByItems;
-        this.orderValuesCaseSensitive = getOrderValuesCaseSensitive();
+        this.orderValuesCaseSensitive = getOrderValuesCaseSensitive(selectStatementContext, schemaMetaData);
     }
     
     @SneakyThrows
-    private List<Boolean> getOrderValuesCaseSensitive() {
+    private List<Boolean> getOrderValuesCaseSensitive(final SelectStatementContext selectStatementContext, final SchemaMetaData schemaMetaData) {
         List<Boolean> result = new ArrayList<>(orderByItems.size());
-        for (OrderByItem each : orderByItems) {
-            result.add(queryResult.isCaseSensitive(each.getIndex()));
+        for (OrderByItem eachOrderByItem : orderByItems) {
+            for (SimpleTableSegment eachSimpleTableSegment : selectStatementContext.getAllTables()) {
+                String tableName = eachSimpleTableSegment.getTableName().getIdentifier().getValue();
+                TableMetaData tableMetaData = schemaMetaData.get(tableName);
+                Map<String, ColumnMetaData> columns = tableMetaData.getColumns();
+                OrderByItemSegment orderByItemSegment = eachOrderByItem.getSegment();
+                if (orderByItemSegment instanceof ColumnOrderByItemSegment) {
+                    String columnName = ((ColumnOrderByItemSegment) orderByItemSegment).getColumn().getIdentifier().getValue();
+                    if (columns.containsKey(columnName)) {
+                        result.add(columns.get(columnName).isCaseSensitive());
+                        break;
+                    }
+                } else if (orderByItemSegment instanceof IndexOrderByItemSegment) {
+                    int columnIndex = ((IndexOrderByItemSegment) orderByItemSegment).getColumnIndex();
+                    if (columns.values().toArray().length >= columnIndex) {
+                        result.add(((ColumnMetaData) columns.values().toArray()[columnIndex - 1]).isCaseSensitive());
+                        break;
+                    }
+                } else {
+                    result.add(false);
+                    break;
 
 Review comment:
   Fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

terrymanu commented on a change in pull request #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r395422927
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaData.java
 ##########
 @@ -36,4 +37,7 @@
     private final String dataType;
     
     private final boolean primaryKey;
+    
+    @Setter
+    private boolean isCaseSensitive;
 
 Review comment:
   Please consider change `isCaseSensitive` to `caseSensitive`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 10440](https://coveralls.io/builds/29495725)
   
   * **39** of **75**   **(52.0%)**  changed or added relevant lines in **9** files are covered.
   * **25** unchanged lines in **7** files lost coverage.
   * Overall coverage decreased (**-1.05%**) to **58.587%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptColumnMetaData.java](https://coveralls.io/builds/29495725/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptColumnMetaData.java#L41) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29495725/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29495725/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29495725/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/groupby/GroupByMemoryMergedResult.java](https://coveralls.io/builds/29495725/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Fgroupby%2FGroupByMemoryMergedResult.java#L132) | 11 | 12 | 91.67%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java](https://coveralls.io/builds/29495725/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Forderby%2FOrderByValue.java#L78) | 18 | 22 | 81.82%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29495725/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L57) | 0 | 27 | 0.0%
   <!-- | **Total:** | **39** | **75** | **52.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29495725/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L77) | 1 | 0% |
   | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/29495725/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29495725/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L119) | 3 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29495725/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouter.java](https://coveralls.io/builds/29495725/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouter.java#L166) | 4 | 34.48% |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29495725/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L86) | 4 | 62.5% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29495725/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L108) | 9 | 1.54% |
   <!-- | **Total:** | **25** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29495725/badge)](https://coveralls.io/builds/29495725) |
   | :-- | --: |
   | Change from base [Build 1120](https://coveralls.io/builds/29467416): |  -1.05% |
   | Covered Lines: | 11919 |
   | Relevant Lines: | 20344 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 2215](https://coveralls.io/builds/29541283)
   
   * **44** of **103**   **(42.72%)**  changed or added relevant lines in **23** files are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.02%**) to **58.192%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptColumnMetaData.java](https://coveralls.io/builds/29541283/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptColumnMetaData.java#L41) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java](https://coveralls.io/builds/29541283/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingTableMetaDataDecorator.java#L53) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29541283/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29541283/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29541283/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/groupby/GroupByMemoryMergedResult.java](https://coveralls.io/builds/29541283/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Fgroupby%2FGroupByMemoryMergedResult.java#L132) | 11 | 12 | 91.67%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/MasterSlaveSchema.java](https://coveralls.io/builds/29541283/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FMasterSlaveSchema.java#L79) | 0 | 1 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShadowSchema.java](https://coveralls.io/builds/29541283/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShadowSchema.java#L71) | 0 | 1 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/TransparentSchema.java](https://coveralls.io/builds/29541283/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FTransparentSchema.java#L63) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaDataLoader.java](https://coveralls.io/builds/29541283/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaDataLoader.java#L46) | 0 | 1 | 0.0%
   <!-- | **Total:** | **44** | **103** | **42.72%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29541283/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L98) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29541283/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L79) | 1 | 0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29541283/badge)](https://coveralls.io/builds/29541283) |
   | :-- | --: |
   | Change from base [Build 1143](https://coveralls.io/builds/29530464): |  0.02% |
   | Covered Lines: | 11905 |
   | Relevant Lines: | 20458 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 2191](https://coveralls.io/builds/29496301)
   
   * **39** of **75**   **(52.0%)**  changed or added relevant lines in **9** files are covered.
   * **22** unchanged lines in **6** files lost coverage.
   * Overall coverage decreased (**-1.0%**) to **58.666%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptColumnMetaData.java](https://coveralls.io/builds/29496301/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptColumnMetaData.java#L41) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29496301/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29496301/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 1 | 2 | 50.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29496301/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/groupby/GroupByMemoryMergedResult.java](https://coveralls.io/builds/29496301/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Fgroupby%2FGroupByMemoryMergedResult.java#L132) | 11 | 12 | 91.67%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java](https://coveralls.io/builds/29496301/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Forderby%2FOrderByValue.java#L78) | 18 | 22 | 81.82%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29496301/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L57) | 0 | 27 | 0.0%
   <!-- | **Total:** | **39** | **75** | **52.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29496301/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L77) | 1 | 0% |
   | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/29496301/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29496301/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L119) | 3 | 0% |
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouter.java](https://coveralls.io/builds/29496301/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouter.java#L166) | 4 | 34.48% |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29496301/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L86) | 4 | 62.5% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29496301/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L108) | 9 | 1.54% |
   <!-- | **Total:** | **22** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29496301/badge)](https://coveralls.io/builds/29496301) |
   | :-- | --: |
   | Change from base [Build 1120](https://coveralls.io/builds/29467416): |  -1.0% |
   | Covered Lines: | 11935 |
   | Relevant Lines: | 20344 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4850: #4460, fix order by string column exception

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601301178
 
 
   ## Pull Request Test Coverage Report for [Build 10427](https://coveralls.io/builds/29492704)
   
   * **25** of **52**   **(48.08%)**  changed or added relevant lines in **7** files are covered.
   * **25** unchanged lines in **7** files lost coverage.
   * Overall coverage decreased (**-0.1%**) to **59.53%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/MemoryQueryResult.java](https://coveralls.io/builds/29492704/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FMemoryQueryResult.java#L160) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/sql/execute/result/StreamQueryResult.java](https://coveralls.io/builds/29492704/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fsql%2Fexecute%2Fresult%2FStreamQueryResult.java#L131) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMerger.java](https://coveralls.io/builds/29492704/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2FShardingDQLResultMerger.java#L82) | 3 | 4 | 75.0%
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/dql/orderby/OrderByValue.java](https://coveralls.io/builds/29492704/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2Fdql%2Forderby%2FOrderByValue.java#L71) | 17 | 23 | 73.91%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29492704/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L63) | 0 | 18 | 0.0%
   <!-- | **Total:** | **25** | **52** | **48.08%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29492704/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L68) | 1 | 0% |
   | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/29492704/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L193) | 1 | 95.35% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29492704/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L119) | 3 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29492704/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouter.java](https://coveralls.io/builds/29492704/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouter.java#L166) | 4 | 34.48% |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29492704/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L86) | 4 | 62.5% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29492704/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L108) | 9 | 1.54% |
   <!-- | **Total:** | **25** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29492704/badge)](https://coveralls.io/builds/29492704) |
   | :-- | --: |
   | Change from base [Build 1120](https://coveralls.io/builds/29467416): |  -0.1% |
   | Covered Lines: | 12443 |
   | Relevant Lines: | 20902 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services