[GitHub] [arrow] pravindra commented on a change in pull request #7070: ARROW-8646: [Java] Allow UnionListWriter to write null values

[GitBox <gi...@apache.org>]

pravindra commented on a change in pull request #7070:
URL: https://github.com/apache/arrow/pull/7070#discussion_r418421121



##########
File path: java/vector/src/main/codegen/templates/UnionListWriter.java
##########
@@ -178,6 +178,10 @@ public void write(DecimalHolder holder) {
     writer.setPosition(writer.idx()+1);
   }
 
+  public void writeNull() {

Review comment:
       I think the same change is required in UnionFixedSizeListWriter as well.

##########
File path: java/vector/src/test/java/org/apache/arrow/vector/complex/writer/TestComplexWriter.java
##########
@@ -266,6 +266,41 @@ public void listScalarType() {
     }
   }
 
+  @Test
+  public void testListScalarNull() {

Review comment:
       can you please add a small description for the test ? eg.
   
   "Write to a integer list vector, each list of size 8 and having it's data values alternating between null and a non-null. Read and verify".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org