You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/05 18:14:17 UTC
[GitHub] [incubator-pinot] akshayrai commented on issue #5113: [TE] added a
couple of validations to check if detection is subscribed & valid;
cleaned up other validations
akshayrai commented on issue #5113: [TE] added a couple of validations to check if detection is subscribed & valid; cleaned up other validations
URL: https://github.com/apache/incubator-pinot/pull/5113#issuecomment-595371758
> 1. Can expose multiple error messages together.
That might be better but I am sure how much value it will bring. We can club together some independent validations and show them together but we still won't be able to run validation on the complete config.
> 2. Easier to add more validation rules.
The validations are already abstracted out and written in a separate validation class. What are you thinking about?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org