You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/07 15:59:36 UTC
[GitHub] [apisix] Firstsawyou opened a new pull request #4003: docs: faq doc add use the FQDN address
Firstsawyou opened a new pull request #4003:
URL: https://github.com/apache/apisix/pull/4003
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4003:
URL: https://github.com/apache/apisix/pull/4003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616329823
##########
File path: docs/en/latest/FAQ.md
##########
@@ -401,24 +401,24 @@ In route, we can achieve more condition matching by combining `uri` with `vars`
## Does the upstream node support configuring the [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) address
-This is supported. Here is an example where the `FQDN` is `localhost.localdomain`:
+This is supported. Here is an example where the `FQDN` is `httpbin.default.svc.cluster.local`:
Review comment:
Need to remove the repeated "Here is an example where the `FQDN` is `httpbin.default.svc.cluster.local`"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r609230127
##########
File path: docs/en/latest/FAQ.md
##########
@@ -392,9 +392,33 @@ HTTP/1.1 200 OK
...
# The uri match failed
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
In route, we can achieve more condition matching by combining `uri` with `vars` field. For more details of using `vars`, please refer to [lua-resty-expr](https://github.com/api7/lua-resty-expr).
+
+## Does the upstream node support configuring the `FQDN`(Fully Qualified Domain Name） address
+
+This is supported. Here is an example where the `FQDN` is `localhost.localdomain.com`:
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+ "uri": "/hello",
+ "upstream": {
+ "type": "roundrobin",
+ "nodes": {
+ "localhost.localdomain.com:1980": 1
Review comment:
Use a FQDN of Kubernetes Service is more vivid.
##########
File path: docs/en/latest/FAQ.md
##########
@@ -392,9 +392,33 @@ HTTP/1.1 200 OK
...
# The uri match failed
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
In route, we can achieve more condition matching by combining `uri` with `vars` field. For more details of using `vars`, please refer to [lua-resty-expr](https://github.com/api7/lua-resty-expr).
+
+## Does the upstream node support configuring the `FQDN`(Fully Qualified Domain Name） address
Review comment:
You may add a hyperlink about `FQDN`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r609195794
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -393,9 +393,33 @@ HTTP/1.1 200 OK
...
# uri 匹配失败
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
在 route 中，我们可以通过 `uri` 结合 `vars` 字段来实现更多的条件匹配，`vars` 的更多使用细节请参考 [lua-resty-expr](https://github.com/api7/lua-resty-expr)。
+
+## upstream 节点是否支持配置 `FQDN`（Fully Qualified Domain Name） 地址
+
+这是支持，下面是一个 `FQDN` 为 `localhost.localdomain.com` 的示例：
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+ "uri": "/hello",
+ "upstream": {
+ "type": "roundrobin",
+ "nodes": {
+ "localhost.localdomain.com:1980": 1
+ }
+ }
+}'
+```
+
+```shell
+# 测试请求
+$ curl http://127.0.0.1:9080/hello -i
Review comment:
This is not a real test, because the FQDN address I configured did not resolve to the local host. I will update it later for a local test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616348606
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -402,7 +402,7 @@ HTTP/1.1 404 Not Found
## upstream 节点是否支持配置 [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) 地址?
-这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local`(a Kubernetes Service) 的示例：
+这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local`(Kubernetes 的 Service) 的示例：
Review comment:
```suggestion
这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local`(一个 Kubernetes Service) 的示例：
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r615816816
##########
File path: docs/en/latest/FAQ.md
##########
@@ -401,24 +401,24 @@ In route, we can achieve more condition matching by combining `uri` with `vars`
## Does the upstream node support configuring the [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) address
-This is supported. Here is an example where the `FQDN` is `localhost.localdomain`:
+This is supported. Here is an example where the `FQDN` is `httpbin.default.svc.cluster.local`:
Review comment:
Add some notes to hint readers:
This is supported. Here is an example where the `FQDN` is `httpbin.default.svc.cluster.local` (a Kubernetes Service):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616042812
##########
File path: docs/en/latest/FAQ.md
##########
@@ -401,24 +401,24 @@ In route, we can achieve more condition matching by combining `uri` with `vars`
## Does the upstream node support configuring the [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) address
-This is supported. Here is an example where the `FQDN` is `localhost.localdomain`:
+This is supported. Here is an example where the `FQDN` is `httpbin.default.svc.cluster.local`:
Review comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616273109
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -402,7 +402,7 @@ HTTP/1.1 404 Not Found
## upstream 节点是否支持配置 [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) 地址?
-这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local` 的示例：
+这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local`(a Kubernetes Service) 的示例：
Review comment:
This is the FAQ docs in Chinese, don't just copy and paste!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616043313
##########
File path: docs/en/latest/FAQ.md
##########
@@ -392,9 +392,33 @@ HTTP/1.1 200 OK
...
# The uri match failed
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
In route, we can achieve more condition matching by combining `uri` with `vars` field. For more details of using `vars`, please refer to [lua-resty-expr](https://github.com/api7/lua-resty-expr).
+
+## Does the upstream node support configuring the `FQDN`(Fully Qualified Domain Name） address
Review comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r609150699
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -393,9 +393,33 @@ HTTP/1.1 200 OK
...
# uri 匹配失败
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
在 route 中，我们可以通过 `uri` 结合 `vars` 字段来实现更多的条件匹配，`vars` 的更多使用细节请参考 [lua-resty-expr](https://github.com/api7/lua-resty-expr)。
+
+## upstream 节点是否支持配置 `FQDN`（Fully Qualified Domain Name） 地址
+
+这是支持，下面是一个 `FQDN` 为 `localhost.localdomain.com` 的示例：
Review comment:
Grammar is wrong
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -393,9 +393,33 @@ HTTP/1.1 200 OK
...
# uri 匹配失败
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
在 route 中，我们可以通过 `uri` 结合 `vars` 字段来实现更多的条件匹配，`vars` 的更多使用细节请参考 [lua-resty-expr](https://github.com/api7/lua-resty-expr)。
+
+## upstream 节点是否支持配置 `FQDN`（Fully Qualified Domain Name） 地址
+
+这是支持，下面是一个 `FQDN` 为 `localhost.localdomain.com` 的示例：
+
+```shell
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+ "uri": "/hello",
+ "upstream": {
+ "type": "roundrobin",
+ "nodes": {
+ "localhost.localdomain.com:1980": 1
+ }
+ }
+}'
+```
+
+```shell
+# 测试请求
+$ curl http://127.0.0.1:9080/hello -i
Review comment:
are you really test？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#issuecomment-821744446
ping @Firstsawyou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616348282
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -402,7 +402,7 @@ HTTP/1.1 404 Not Found
## upstream 节点是否支持配置 [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) 地址?
-这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local` 的示例：
+这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local`(a Kubernetes Service) 的示例：
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616362467
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -402,7 +402,7 @@ HTTP/1.1 404 Not Found
## upstream 节点是否支持配置 [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) 地址?
-这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local`(a Kubernetes Service) 的示例：
+这是支持的，下面是一个 `FQDN` 为 `httpbin.default.svc.cluster.local`(Kubernetes 的 Service) 的示例：
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616329823
##########
File path: docs/en/latest/FAQ.md
##########
@@ -401,24 +401,24 @@ In route, we can achieve more condition matching by combining `uri` with `vars`
## Does the upstream node support configuring the [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) address
-This is supported. Here is an example where the `FQDN` is `localhost.localdomain`:
+This is supported. Here is an example where the `FQDN` is `httpbin.default.svc.cluster.local`:
Review comment:
Need to remove the repeated `Here is an example where the `FQDN` is `httpbin.default.svc.cluster.local``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4003: docs: faq doc add use the FQDN address
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #4003:
URL: https://github.com/apache/apisix/pull/4003#discussion_r616043021
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -393,9 +393,33 @@ HTTP/1.1 200 OK
...
# uri 匹配失败
-curl http://127.0.0.1:9080/12ab -i
+$ curl http://127.0.0.1:9080/12ab -i
HTTP/1.1 404 Not Found
...
```
在 route 中，我们可以通过 `uri` 结合 `vars` 字段来实现更多的条件匹配，`vars` 的更多使用细节请参考 [lua-resty-expr](https://github.com/api7/lua-resty-expr)。
+
+## upstream 节点是否支持配置 `FQDN`（Fully Qualified Domain Name） 地址
+
+这是支持，下面是一个 `FQDN` 为 `localhost.localdomain.com` 的示例：
Review comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org