[Bug 5293] RFE: pluginize the Bayes subsystem

[bu...@bugzilla.spamassassin.org]

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5293





------- Additional Comments From jm@jmason.org  2007-12-10 06:42 -------
I've now merged this up to current SVN trunk's HEAD, and added documentation to
Plugin.pm for the new APIs.  There are a few minor updates:

- 'sanity_check_bayes_is_untied': I renamed this to the much clearer
  'learner_close', which is, it turns out, what it should be used for. ;) It's
  just our basic impl that optimises things to such an extent that it's
  actually used as just a sanity check.

- 'learner_get_implementation' is less thorny now, since it is only used in the
  bayes-specific test cases.

- the {bayes} member in the Mail::SpamAssassin::BayesStore classes is now a ref
  to a Mail::SpamAssassin::Plugin::Bayes object, not a
  Mail::SpamAssassin::Bayes.

- there are duplicates of the Mail::SpamAssassin::BayesStore classes under
  Mail/SpamAssassin/OSBF/Store, used to provide storage for the experimental
  OSBF classifier (bug 5686).  if we get OSBF working ok, it would be nice
  to refactor to share more code.  no biggie.

- there are config settings for the new, experimental OSBF code commented
  out in Conf.pm.

Otherwise it's unchanged.  I propose to merge this into trunk and get rid
of this branch... speak up if you're not keen ;)

I'll attach the changes in patch form for review.





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.