You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/08/13 06:10:23 UTC

[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1133: Feature: Add cleanup unused microservice job

little-cui commented on a change in pull request #1133:
URL: https://github.com/apache/servicecomb-service-center/pull/1133#discussion_r688267612



##########
File path: datasource/ms.go
##########
@@ -100,4 +100,7 @@ type MetadataManager interface {
 	GetTags(ctx context.Context, request *pb.GetServiceTagsRequest) (*pb.GetServiceTagsResponse, error)
 	UpdateTag(ctx context.Context, request *pb.UpdateServiceTagRequest) (*pb.UpdateServiceTagResponse, error)
 	DeleteTags(ctx context.Context, request *pb.DeleteServiceTagsRequest) (*pb.DeleteServiceTagsResponse, error)
+
+	// CleanupUnusedMicroservice keep the 'reserveVersionCount' latest versions
+	CleanupUnusedMicroservice(ctx context.Context, reserveVersionCount int) error

Review comment:
       改名为Rotate




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org