[GitHub] [nifi] Lehel44 commented on pull request #6268: NIFI-10244 Add nifi-web-client-api and implementation

[GitBox <gi...@apache.org>]

Lehel44 commented on PR #6268:
URL: https://github.com/apache/nifi/pull/6268#issuecomment-1210850600

   Thanks for the contribution @exceptionfactory. I went through the code and overall I like the clean design and the functionality. A few small comments:
   - I tested the UriBuilder, it's easy to use and functionally works well.
   - I prefer the builder pattern instead of the fixed interface order, but since http requests consist of 3 fixed parts and this will not be extended, and since it would require changing the whole design and is a matter of taste anyway, it's still perfectly usable.
   - I tried out the WebClientService. I created a custom processor that sends different HTTP requests to a HandleHttpRequest -> HandleHttpResponse NiFi flow. I have tested the service using TLS and a proxy server. The settings from the specified proxy service and SSLContextService are appropriately read by the processor.
   LGTM+1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org