You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by mohammadshahidkhan <gi...@git.apache.org> on 2018/03/01 05:02:27 UTC
[GitHub] carbondata pull request #2014: [CARBONDATA-2198] Fixed bug for streaming dat...
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2014#discussion_r171463779
--- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/streaming/CarbonStreamRecordWriter.java ---
@@ -181,75 +181,81 @@ private void initializeAtFirstRow() throws IOException, InterruptedException {
initializeAtFirstRow();
}
- // parse and convert row
- currentRow.setData(rowParser.parseRow((Object[]) value));
- converter.convert(currentRow);
-
// null bit set
nullBitSet.clear();
- for (int i = 0; i < dataFields.length; i++) {
- if (null == currentRow.getObject(i)) {
- nullBitSet.set(i);
+ Object[] rowData = (Object[]) value;
+ currentRow.setRawData(rowData);
+ // parse and convert row
+ currentRow.setData(rowParser.parseRow(rowData));
+ CarbonRow updatedCarbonRow = converter.convert(currentRow);
+ if (updatedCarbonRow == null) {
+ output.skipRow();
+ currentRow.clearData();
+ } else {
--- End diff --
@geetikagupta16 Thanks for working on this
Hope no change in the else part, only formatting changed due the if check.
---