[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #2261: Introduce RowLayout to represent rows for different purposes

[GitBox <gi...@apache.org>]

yjshen commented on code in PR #2261:
URL: https://github.com/apache/arrow-datafusion/pull/2261#discussion_r852027987


##########
datafusion/core/src/row/layout.rs:
##########
@@ -17,26 +17,94 @@
 
 //! Various row layout for different use case
 
-use crate::row::{schema_null_free, var_length};
+use crate::row::{row_supported, schema_null_free, var_length};
 use arrow::datatypes::{DataType, Schema};
 use arrow::util::bit_util::{ceil, round_upto_power_of_2};
+use std::fmt::{Debug, Formatter};
 use std::sync::Arc;
 
 const UTF8_DEFAULT_SIZE: usize = 20;
 const BINARY_DEFAULT_SIZE: usize = 100;
 
+#[derive(Copy, Clone, Debug)]

Review Comment:
   The main changes are below. Other files changes are almost mechanical.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org