You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/02/27 14:07:34 UTC

Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-20210
    https://issues.apache.org/jira/browse/AMBARI-20210


Repository: ambari


Description
-------

While yarn service is stopped, "refresh queue" call will trigger command to
post refresh call for the yarn with infinite amount of retry amount, which
blocks us queue processing.

We should allow to kill this command after certain amount of time, to
implement fast fail feature.


Diffs
-----

  ambari-common/src/main/python/resource_management/core/signal_utils.py 1f0dfe7 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py 03b66a5 

Diff: https://reviews.apache.org/r/57092/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On Feb. 27, 2017, 2:09 p.m., Dmitro Lisnichenko wrote:
> > ambari-common/src/main/python/resource_management/core/signal_utils.py, line 26
> > <https://reviews.apache.org/r/57092/diff/1/?file=1650281#file1650281line26>
> >
> >     looks like unused import

it is used on line 68 of the file.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/#review166864
-----------------------------------------------------------


On Feb. 27, 2017, 2:07 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57092/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 2:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20210
>     https://issues.apache.org/jira/browse/AMBARI-20210
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> While yarn service is stopped, "refresh queue" call will trigger command to
> post refresh call for the yarn with infinite amount of retry amount, which
> blocks us queue processing.
> 
> We should allow to kill this command after certain amount of time, to
> implement fast fail feature.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/signal_utils.py 1f0dfe7 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py 03b66a5 
> 
> Diff: https://reviews.apache.org/r/57092/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/#review166864
-----------------------------------------------------------


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/core/signal_utils.py (line 26)
<https://reviews.apache.org/r/57092/#comment238944>

    looks like unused import


- Dmitro Lisnichenko


On Feb. 27, 2017, 4:07 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57092/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 4:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20210
>     https://issues.apache.org/jira/browse/AMBARI-20210
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> While yarn service is stopped, "refresh queue" call will trigger command to
> post refresh call for the yarn with infinite amount of retry amount, which
> blocks us queue processing.
> 
> We should allow to kill this command after certain amount of time, to
> implement fast fail feature.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/signal_utils.py 1f0dfe7 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py 03b66a5 
> 
> Diff: https://reviews.apache.org/r/57092/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On Feb. 27, 2017, 6:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py, line 107
> > <https://reviews.apache.org/r/57092/diff/1/?file=1650282#file1650282line107>
> >
> >     The same change is needed in YARN 3.0.0.3.0

Thanks Alejandro. Fixed in AMBARI-20233


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/#review166903
-----------------------------------------------------------


On Feb. 27, 2017, 2:07 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57092/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 2:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20210
>     https://issues.apache.org/jira/browse/AMBARI-20210
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> While yarn service is stopped, "refresh queue" call will trigger command to
> post refresh call for the yarn with infinite amount of retry amount, which
> blocks us queue processing.
> 
> We should allow to kill this command after certain amount of time, to
> implement fast fail feature.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/signal_utils.py 1f0dfe7 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py 03b66a5 
> 
> Diff: https://reviews.apache.org/r/57092/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/#review166903
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py (line 107)
<https://reviews.apache.org/r/57092/#comment238993>

    The same change is needed in YARN 3.0.0.3.0


- Alejandro Fernandez


On Feb. 27, 2017, 2:07 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57092/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 2:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20210
>     https://issues.apache.org/jira/browse/AMBARI-20210
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> While yarn service is stopped, "refresh queue" call will trigger command to
> post refresh call for the yarn with infinite amount of retry amount, which
> blocks us queue processing.
> 
> We should allow to kill this command after certain amount of time, to
> implement fast fail feature.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/signal_utils.py 1f0dfe7 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py 03b66a5 
> 
> Diff: https://reviews.apache.org/r/57092/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>