You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/22 11:02:25 UTC

[GitHub] [beam] je-ik edited a comment on pull request #13592: [BEAM-11403] Cache UnboundedReader per CheckpointMark in SDF Wrapper DoFn.

je-ik edited a comment on pull request #13592:
URL: https://github.com/apache/beam/pull/13592#issuecomment-749467845


   One more concern - the current implementation relies on `CheckpointMark#hashCode` and `CheckpointMark#equals`. It is likely that these will not have these two correctly implemented. We should stick to `Coder#structuralValue` for that.
   The same holds true for UnboundedSource#hashCode and equals, we should probably not use the source in the cache key, because it should be impossible for single DoFn instance to read from multiple readers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org