You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/07/18 19:08:43 UTC

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #3739: TP: adds the ability to rearrange delivery service table columns as well as toggle column visibility/searchability

mitchell852 opened a new pull request #3739: TP: adds the ability to rearrange delivery service table columns as well as toggle column visibility/searchability
URL: https://github.com/apache/trafficcontrol/pull/3739
 
 
   ## What does this PR (Pull Request) do?
   
   - [x] This PR is not related to any Issue
   
   This PR adds checkboxes to toggle the visiblity/searchability of ds table columns as well as adds the ability to reorder the columns.
   
   ![image](https://user-images.githubusercontent.com/251272/61484811-e5437700-a95c-11e9-907f-b93cbbb1cff9.png)
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   
   Navigate to https://tp.doman.com/#!/delivery-services and
   
   1. reorder the columns; refresh the screen to ensure that the new order persists itself across browser sessions.
   2. click on the drop down to toggle the visiblity/searchability of columns; refresh the screen to ensure that the selected columns are visible/hidden across browser sessions. also, ensure that values in hidden columns are not considered in the table search.
   
   ## The following criteria are ALL met by this PR
   
   - [ ] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation is unnecessary
   - [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [ ] This PR includes any and all required license headers
   - [ ] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services