You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/06 03:56:55 UTC
[GitHub] [dubbo-go-pixiu] tydhot opened a new pull request #204: add otel metric in pixiu (now is stdout)
tydhot opened a new pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88701d3) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ca07c24a12499462699c4c38fbf84f41055159a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca07c24) will **decrease** coverage by `0.62%`.
> The diff coverage is `10.41%`.
> :exclamation: Current head 88701d3 differs from pull request most recent head 00c089e. Consider uploading reports for the commit 00c089e to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 40.33% 39.71% -0.63%
===========================================
Files 39 40 +1
Lines 2355 2397 +42
===========================================
+ Hits 950 952 +2
- Misses 1303 1343 +40
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.64% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `37.03% <25.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ca07c24...00c089e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] tydhot commented on a change in pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#discussion_r667312941
##########
File path: pkg/filter/metric/metric.go
##########
@@ -15,9 +15,11 @@
* limitations under the License.
*/
-package logger
+package metric
import (
+ ctx "context"
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #204: add otel metric in pixiu (now is stdout)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40b5163) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/9c3b19940e47bebeebe392cf5657430ca25b717b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c3b199) will **decrease** coverage by `0.67%`.
> The diff coverage is `6.97%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 39.35% 38.67% -0.68%
===========================================
Files 39 40 +1
Lines 1987 2027 +40
===========================================
+ Hits 782 784 +2
- Misses 1107 1145 +38
Partials 98 98
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.58% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `36.36% <18.75%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c3b199...40b5163](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (732443a) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a4f790badaede20fa4f96ae74ebddcb0edabfc36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4f790b) will **decrease** coverage by `0.62%`.
> The diff coverage is `10.41%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 40.33% 39.71% -0.63%
===========================================
Files 39 40 +1
Lines 2355 2397 +42
===========================================
+ Hits 950 952 +2
- Misses 1303 1343 +40
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.64% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `37.03% <25.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a4f790b...732443a](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed3eb5d) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/b4845221ed76804f5d8b0e7cbdef7dcc1afcb94e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b484522) will **decrease** coverage by `0.62%`.
> The diff coverage is `10.41%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 40.36% 39.74% -0.63%
===========================================
Files 39 40 +1
Lines 2356 2398 +42
===========================================
+ Hits 951 953 +2
- Misses 1303 1343 +40
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.64% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `37.03% <25.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b484522...ed3eb5d](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca84643) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2ced699ed5f5778ac445e24632fe89ac37dca83f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ced699) will **decrease** coverage by `0.62%`.
> The diff coverage is `10.41%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 40.35% 39.73% -0.63%
===========================================
Files 39 40 +1
Lines 2354 2396 +42
===========================================
+ Hits 950 952 +2
- Misses 1302 1342 +40
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.64% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `37.03% <25.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2ced699...ca84643](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24a2d74) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ffc58b6261cac2fcbfdae6e64caa619cc08da899?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffc58b6) will **increase** coverage by `0.38%`.
> The diff coverage is `10.41%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
+ Coverage 39.35% 39.74% +0.38%
===========================================
Files 39 40 +1
Lines 1987 2398 +411
===========================================
+ Hits 782 953 +171
- Misses 1107 1343 +236
- Partials 98 102 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.64% <0.00%> (+0.05%)` | :arrow_up: |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `37.03% <25.00%> (ø)` | |
| [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `69.23% <0.00%> (-8.55%)` | :arrow_down: |
| [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `86.66% <0.00%> (-4.25%)` | :arrow_down: |
| [pkg/filter/timeout/timeout.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci90aW1lb3V0L3RpbWVvdXQuZ28=) | `90.62% <0.00%> (-1.97%)` | :arrow_down: |
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `79.31% <0.00%> (-1.65%)` | :arrow_down: |
| [pkg/service/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZpY2UvYXBpL2Rpc2NvdmVyeV9zZXJ2aWNlLmdv) | `41.79% <0.00%> (-0.52%)` | :arrow_down: |
| [pkg/router/route.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JvdXRlci9yb3V0ZS5nbw==) | `78.12% <0.00%> (-0.19%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ffc58b6...24a2d74](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric in pixiu (now is stdout)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cadc7c5) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/9c3b19940e47bebeebe392cf5657430ca25b717b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c3b199) will **decrease** coverage by `0.67%`.
> The diff coverage is `6.97%`.
> :exclamation: Current head cadc7c5 differs from pull request most recent head 40b5163. Consider uploading reports for the commit 40b5163 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 39.35% 38.67% -0.68%
===========================================
Files 39 40 +1
Lines 1987 2027 +40
===========================================
+ Hits 782 784 +2
- Misses 1107 1145 +38
Partials 98 98
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.58% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `36.36% <18.75%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c3b199...40b5163](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c30f9a) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ffc58b6261cac2fcbfdae6e64caa619cc08da899?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffc58b6) will **increase** coverage by `0.38%`.
> The diff coverage is `10.41%`.
> :exclamation: Current head 0c30f9a differs from pull request most recent head 24a2d74. Consider uploading reports for the commit 24a2d74 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
+ Coverage 39.35% 39.74% +0.38%
===========================================
Files 39 40 +1
Lines 1987 2398 +411
===========================================
+ Hits 782 953 +171
- Misses 1107 1343 +236
- Partials 98 102 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.64% <0.00%> (+0.05%)` | :arrow_up: |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `37.03% <25.00%> (ø)` | |
| [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `69.23% <0.00%> (-8.55%)` | :arrow_down: |
| [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `86.66% <0.00%> (-4.25%)` | :arrow_down: |
| [pkg/filter/timeout/timeout.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci90aW1lb3V0L3RpbWVvdXQuZ28=) | `90.62% <0.00%> (-1.97%)` | :arrow_down: |
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `79.31% <0.00%> (-1.65%)` | :arrow_down: |
| [pkg/service/api/discovery\_service.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZpY2UvYXBpL2Rpc2NvdmVyeV9zZXJ2aWNlLmdv) | `41.79% <0.00%> (-0.52%)` | :arrow_down: |
| [pkg/router/route.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JvdXRlci9yb3V0ZS5nbw==) | `78.12% <0.00%> (-0.19%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ffc58b6...24a2d74](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00c089e) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/ca07c24a12499462699c4c38fbf84f41055159a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca07c24) will **decrease** coverage by `0.62%`.
> The diff coverage is `10.41%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 40.33% 39.71% -0.63%
===========================================
Files 39 40 +1
Lines 2355 2397 +42
===========================================
+ Hits 950 952 +2
- Misses 1303 1343 +40
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.64% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `37.03% <25.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ca07c24...00c089e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] tydhot commented on a change in pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#discussion_r664668873
##########
File path: pkg/filter/metric/metric.go
##########
@@ -30,33 +32,60 @@ import (
"github.com/apache/dubbo-go-pixiu/pkg/common/constant"
"github.com/apache/dubbo-go-pixiu/pkg/common/extension"
"github.com/apache/dubbo-go-pixiu/pkg/logger"
+ "go.opentelemetry.io/otel/metric"
+ "go.opentelemetry.io/otel/metric/global"
+)
+
+var (
+ totalElapsed int64 = 0
Review comment:
thanks！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (666f6ca) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/0106e81e80684021d840ca4a9778f40e83de36f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0106e81) will **decrease** coverage by `3.76%`.
> The diff coverage is `39.37%`.
> :exclamation: Current head 666f6ca differs from pull request most recent head 00c089e. Consider uploading reports for the commit 00c089e to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 43.47% 39.71% -3.77%
===========================================
Files 32 40 +8
Lines 1357 2397 +1040
===========================================
+ Hits 590 952 +362
- Misses 684 1343 +659
- Partials 83 102 +19
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/client/http/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL3Jlc3BvbnNlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/client/request.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXF1ZXN0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <ø> (ø)` | |
| [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `86.66% <ø> (-4.25%)` | :arrow_down: |
| [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
| [pkg/context/http/writer.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC93cml0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| ... and [53 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ca07c24...00c089e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #204: add otel metric in pixiu (now is stdout)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40b5163) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/9c3b19940e47bebeebe392cf5657430ca25b717b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c3b199) will **decrease** coverage by `0.67%`.
> The diff coverage is `6.97%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 39.35% 38.67% -0.68%
===========================================
Files 39 40 +1
Lines 1987 2027 +40
===========================================
+ Hits 782 784 +2
- Misses 1107 1145 +38
Partials 98 98
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.58% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `36.36% <18.75%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c3b199...40b5163](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #204: add otel metric in pixiu (now is stdout)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-874511903
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#204](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cadc7c5) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/9c3b19940e47bebeebe392cf5657430ca25b717b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c3b199) will **decrease** coverage by `0.67%`.
> The diff coverage is `6.97%`.
> :exclamation: Current head cadc7c5 differs from pull request most recent head 40b5163. Consider uploading reports for the commit 40b5163 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 39.35% 38.67% -0.68%
===========================================
Files 39 40 +1
Lines 1987 2027 +40
===========================================
+ Hits 782 784 +2
- Misses 1107 1145 +38
Partials 98 98
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/pixiu/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L2xpc3RlbmVyLmdv) | `19.58% <0.00%> (ø)` | |
| [pkg/pixiu/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L290ZWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/pixiu/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BpeGl1L3BpeGl1X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `36.36% <18.75%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c3b199...40b5163](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/204?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#discussion_r667303827
##########
File path: pkg/filter/metric/metric.go
##########
@@ -15,9 +15,11 @@
* limitations under the License.
*/
-package logger
+package metric
import (
+ ctx "context"
Review comment:
这种已经很简单的词语，就没必要简化了。你把包名称简化了，如果我想取个同样的变量名称，就没法取名了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#discussion_r664658273
##########
File path: pkg/filter/metric/metric.go
##########
@@ -30,33 +32,60 @@ import (
"github.com/apache/dubbo-go-pixiu/pkg/common/constant"
"github.com/apache/dubbo-go-pixiu/pkg/common/extension"
"github.com/apache/dubbo-go-pixiu/pkg/logger"
+ "go.opentelemetry.io/otel/metric"
+ "go.opentelemetry.io/otel/metric/global"
+)
+
+var (
+ totalElapsed int64 = 0
Review comment:
在 go 里面，初始值为 0 时，不用赋值。因为其默认值就是 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #204: add otel metric export to prometheus in pixiu
Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #204:
URL: https://github.com/apache/dubbo-go-pixiu/pull/204#issuecomment-877797247
filter init not good, I'll fix it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org