Re: svn commit: r28125 - trunk/subversion/include/private

[Karl Fogel <kf...@red-bean.com>]

kfogel@tigris.org writes:
> Log:
> * subversion/include/private/svn_fs_mergeinfo.h
>   (svn_fs_mergeinfo__get_mergeinfo_for_tree): Formatting fix (80 columns).

This formatting fix called some larger problems to my attention.
Here's the prototype and doc string right now:

   /* Get the combined mergeinfo for the tree under each one of PATHS
      (an array of absolute-in-the-fs paths) under ROOT, and return it
      in *MERGEINFO, mapping char * paths to mergeinfo hashs.  The resulting
      mergeinfo also includes elided mergeinfo for each one of PATHS.  This
      function conforms to the get_mergeinfo_for_tree() interface.  */
   svn_error_t *
   svn_fs_mergeinfo__get_mergeinfo_for_tree(
     apr_hash_t **mergeinfo,
     svn_fs_root_t *root,
     const apr_array_header_t *paths,
     svn_fs_mergeinfo_filter_func_t filter_func,
     void *filter_func_baton,
     apr_pool_t *pool);

FILTER_FUNC and FILTER_FUNC_BATON are not mentioned at all.

POOL is not mentioned, which would be okay if its behavior were
obvious, but actually we need to know if everything set in *MERGEINFO
is allocated in POOL, or if some things are stored by reference (I'm
guessing they're all copied into POOL, but we should be explicit about
it.

Finally, what is the "get_mergeinfo_for_tree() interface" referred to
in the last line?  If an interface name neither begins with
"svn_NAMESPACE_" nor is declared in the same file, then the reader
can't find it.

I think r25138 and later r25189 are where this started.  Hyrum, can
you clarify the doc string?  Thanks.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r28125 - trunk/subversion/include/private

["Hyrum K. Wright" <hy...@mail.utexas.edu>]

David Glasser wrote:
> On Nov 28, 2007 1:32 PM, Karl Fogel <kf...@red-bean.com> wrote:
>> Finally, what is the "get_mergeinfo_for_tree() interface" referred to
>> in the last line?  If an interface name neither begins with
>> "svn_NAMESPACE_" nor is declared in the same file, then the reader
>> can't find it.
> 
> Should be svn_fs_get_mergeinfo_for_tree, which does in fact document
> the other things you've mentioned.

Thanks for doing the digging on that, Dave.

-Hyrum (who is anxiously waiting for the semester to end so he can get
back to hacking svn with increased frequency)

Re: svn commit: r28125 - trunk/subversion/include/private

[David Glasser <gl...@davidglasser.net>]

On Nov 28, 2007 1:32 PM, Karl Fogel <kf...@red-bean.com> wrote:
> Finally, what is the "get_mergeinfo_for_tree() interface" referred to
> in the last line?  If an interface name neither begins with
> "svn_NAMESPACE_" nor is declared in the same file, then the reader
> can't find it.

Should be svn_fs_get_mergeinfo_for_tree, which does in fact document
the other things you've mentioned.

--dave


-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org