You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/13 19:42:45 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
josehernandezfintecheandomx opened a new pull request, #2601:
URL: https://github.com/apache/fineract/pull/2601
## Description
Add `disallowExpectedDisbursements` flag in Loan account API response
[FINERACT-1724](https://issues.apache.org/jira/browse/FINERACT-1724).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2601:
URL: https://github.com/apache/fineract/pull/2601#discussion_r970090516
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -1307,10 +1299,6 @@ public static LoanAccountData associationsAndTemplate(final LoanAccountData acc,
final PaidInAdvanceData paidInAdvance, Collection<InterestRatePeriodData> interestRatesPeriods,
final Collection<LoanAccountSummaryData> clientActiveLoanOptions, final List<RateData> rates, final Boolean isRatesEnabled,
final CollectionData delinquent) {
- LoanProductConfigurableAttributes loanProductConfigurableAttributes = null;
Review Comment:
is there a reason to remove these?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -1080,9 +1074,6 @@ public static LoanAccountData loanProductWithTemplateDefaults(final LoanProductD
final PaidInAdvanceData paidInAdvance = null;
final Collection<InterestRatePeriodData> interestRatesPeriods = null;
- final Boolean isVariableInstallmentsAllowed = Boolean.FALSE;
Review Comment:
is there a reason to remove these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on PR #2601:
URL: https://github.com/apache/fineract/pull/2601#issuecomment-1245964178
@josehernandezfintecheandomx Please check the failing tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2601:
URL: https://github.com/apache/fineract/pull/2601#discussion_r971407268
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -127,6 +126,7 @@ public final class LoanAccountData {
private final LocalDate interestChargedFromDate;
private final LocalDate expectedFirstRepaymentOnDate;
private final Boolean syncDisbursementWithMeeting;
+ private final Boolean disallowExpectedDisbursements;
Review Comment:
Done!
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -127,6 +126,7 @@ public final class LoanAccountData {
private final LocalDate interestChargedFromDate;
private final LocalDate expectedFirstRepaymentOnDate;
private final Boolean syncDisbursementWithMeeting;
+ private final Boolean disallowExpectedDisbursements;
Review Comment:
Can someone explain me that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2601:
URL: https://github.com/apache/fineract/pull/2601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2601:
URL: https://github.com/apache/fineract/pull/2601#discussion_r970701199
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -1307,10 +1299,6 @@ public static LoanAccountData associationsAndTemplate(final LoanAccountData acc,
final PaidInAdvanceData paidInAdvance, Collection<InterestRatePeriodData> interestRatesPeriods,
final Collection<LoanAccountSummaryData> clientActiveLoanOptions, final List<RateData> rates, final Boolean isRatesEnabled,
final CollectionData delinquent) {
- LoanProductConfigurableAttributes loanProductConfigurableAttributes = null;
Review Comment:
Without use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2601:
URL: https://github.com/apache/fineract/pull/2601#discussion_r970701439
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -1080,9 +1074,6 @@ public static LoanAccountData loanProductWithTemplateDefaults(final LoanProductD
final PaidInAdvanceData paidInAdvance = null;
final Collection<InterestRatePeriodData> interestRatesPeriods = null;
- final Boolean isVariableInstallmentsAllowed = Boolean.FALSE;
Review Comment:
Without use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on code in PR #2601:
URL: https://github.com/apache/fineract/pull/2601#discussion_r970702385
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -127,6 +126,7 @@ public final class LoanAccountData {
private final LocalDate interestChargedFromDate;
private final LocalDate expectedFirstRepaymentOnDate;
private final Boolean syncDisbursementWithMeeting;
+ private final Boolean disallowExpectedDisbursements;
Review Comment:
Can someone explain me that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2601:
URL: https://github.com/apache/fineract/pull/2601#discussion_r970022817
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -127,6 +126,7 @@ public final class LoanAccountData {
private final LocalDate interestChargedFromDate;
private final LocalDate expectedFirstRepaymentOnDate;
private final Boolean syncDisbursementWithMeeting;
+ private final Boolean disallowExpectedDisbursements;
Review Comment:
Please add this attribute to the Avro schema as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org