[GitHub] sijie commented on issue #937: Issue 935: Issue 915: Part 3 - Make circe-checksum module work for both java 8 and java 9

[GitBox <gi...@apache.org>]

sijie commented on issue #937: Issue 935: Issue 915: Part 3 - Make circe-checksum module work for both java 8 and java 9
URL: https://github.com/apache/bookkeeper/pull/937#issuecomment-355365626
 
 
   @jvrao 
   
   is your question for benefits of moving pulsar-checksum to bookkeeper? or benefits of making it run with java8 and java9?
   
   for "benefits of moving pulsar-checksum to bookkeeper": since pulsar depends on bookkeeper, this module is used for both bookkeeper and pulsar, it is making sense for pushing this module down to bookkeeper, so it doesn't have recursive dependency.
   
   for "benefits of making it run with java8 and java9": currently the CI validates the builds at both java9 and java8. I need to make changes to make this checksum module can be compiled and run at both java9 and java8.
   
   Hope this explains your question here.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services