[GitHub] [tvm] stevenmburns commented on pull request #8797: VTA cmake change to include Verilator header for building tsim library

[GitBox <gi...@apache.org>]

stevenmburns commented on pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#issuecomment-905027565


   @aasorokiin You can probably be more selective about which warnings to consider as errors.
   Here is an example:
   ```
   > cat a.cpp
   int main() {
      int a;
      return 0;
   }
   ```
   With `-Werror` set, you get a compilation failure:
   ```
   > g++ -Wall -Werror a.cpp
   a.cpp: In function ‘int main()’:
   a.cpp:2:8: error: unused variable ‘a’ [-Werror=unused-variable]
       int a;
           ^
   cc1plus: all warnings being treated as errors
   ```
   But you can turn off that particular error:
   ```
   > g++ -Wall -Werror -Wno-error=unused-variable a.cpp
   a.cpp: In function ‘int main()’:
   a.cpp:2:8: warning: unused variable ‘a’ [-Wunused-variable]
       int a;
           ^
   ```
   This compiles. Maybe you can add the particular Verilator warnings to a `-Wno-error` option to clean this up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org