You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Yi Liu (JIRA)" <ji...@apache.org> on 2015/03/13 03:51:38 UTC
[jira] [Commented] (HADOOP-11711) Provide a default value for
AES/CTR/NoPadding CryptoCodec classes
[ https://issues.apache.org/jira/browse/HADOOP-11711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359839#comment-14359839 ]
Yi Liu commented on HADOOP-11711:
---------------------------------
Thanks [~andrew.wang] for the patch, it looks good to me, +1 pending Jenkins.
I find a really small nit in the test, it would be better if you could address:
{code}
public static final String
HADOOP_SECURITY_CRYPTO_CODEC_CLASSES_AES_CTR_NOPADDING_KEY =
HADOOP_SECURITY_CRYPTO_CODEC_CLASSES_KEY_PREFIX
+ CipherSuite.AES_CTR_NOPADDING.getConfigSuffix();
{code}
In {{CommonConfigurationKeysPublic.java}}, {{HADOOP_SECURITY_CRYPTO_CODEC_CLASSES_AES_CTR_NOPADDING_KEY}} is defined, we could use it in TestCryptoStreamsWithJceAesCtrCryptoCodec.java and TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java instead of constructing the string again.
> Provide a default value for AES/CTR/NoPadding CryptoCodec classes
> -----------------------------------------------------------------
>
> Key: HADOOP-11711
> URL: https://issues.apache.org/jira/browse/HADOOP-11711
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Minor
> Attachments: hadoop-11711.001.patch
>
>
> Users can configure the desired class to use for a given codec via a property like {{hadoop.security.crypto.codec.classes.aes.ctr.nopadding}}. However, even though we provide a default value for this codec in {{core-default.xml}}, this default is not also done in the code.
> As a result, client deployments that do not include {{core-default.xml}} cannot resolve any codecs, and get an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)