You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/03/16 20:26:45 UTC

[PR] [SPARK-56011][PYTHON] Add dev/asv wrapper script for running benchmarks from repo root [spark]

Yicong-Huang opened a new pull request, #54834:
URL: https://github.com/apache/spark/pull/54834

   ## What changes were proposed in this pull request?
   
   Add a `dev/asv` wrapper script so PySpark ASV benchmarks can be run directly from the Spark root directory, and update the benchmarks README accordingly.
   
   ## Why are the changes needed?
   
   Running benchmarks currently requires `cd python/benchmarks` first, which is inconvenient. A root-level wrapper is consistent with other dev scripts like `dev/lint-python`.
   
   ## Does this PR introduce _any_ user-facing change?
   
   No.
   
   ## How was this patch tested?
   
   Manually verified the wrapper script runs `asv` correctly from the repo root.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56011][PYTHON][INFRA] Add python/asv wrapper script for running benchmarks from repo root [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #54834: [SPARK-56011][PYTHON][INFRA] Add python/asv wrapper script for running benchmarks from repo root
URL: https://github.com/apache/spark/pull/54834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56011][PYTHON][INFRA] Add dev/asv wrapper script for running benchmarks from repo root [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #54834:
URL: https://github.com/apache/spark/pull/54834#issuecomment-4071921417

   `python` is better, let's move it to `python`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56011][PYTHON][INFRA] Add dev/asv wrapper script for running benchmarks from repo root [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #54834:
URL: https://github.com/apache/spark/pull/54834#issuecomment-4071292981

   cc @gaogaotiantian @zhengruifeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56011][PYTHON][INFRA] Add dev/asv wrapper script for running benchmarks from repo root [spark]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #54834:
URL: https://github.com/apache/spark/pull/54834#issuecomment-4071508219

   > Why does not it live with `run-tests.py`? I guess `dev` might make sense? Is `python` better?
   
   The difference is put it as `dev/asv` vs `python/asv`. I am fine either way. But I think most dev tools live in `dev`. @zhengruifeng do you want to make a decision here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56011][PYTHON][INFRA] Add python/asv wrapper script for running benchmarks from repo root [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #54834:
URL: https://github.com/apache/spark/pull/54834#issuecomment-4086524399

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56011][PYTHON][INFRA] Add dev/asv wrapper script for running benchmarks from repo root [spark]

Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on PR #54834:
URL: https://github.com/apache/spark/pull/54834#issuecomment-4071355326

   Why does not it live with `run-tests.py`? I guess `dev` might make sense? Is `python` better?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org