You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "liyamahendra (via GitHub)" <gi...@apache.org> on 2023/02/16 05:50:09 UTC

[GitHub] [cordova-docs] liyamahendra commented on a diff in pull request #1285: android: Updated docs for supporting themed icons

liyamahendra commented on code in PR #1285:
URL: https://github.com/apache/cordova-docs/pull/1285#discussion_r1108041095


##########
www/docs/en/dev/config_ref/images.md:
##########
@@ -54,27 +54,28 @@ different screen resolutions.
 
 ## Android
 
-On Android, instead of using a single image for an icon, you can use two images (background and foreground) to create an **Adaptive Icon**. To use Adaptive Icons, you need to have installed at least version 9.0.0 of **Cordova** and version 8.0.0 of **Cordova-Android**.
+On Android, instead of using a single image for an icon, you can use two images (background and foreground) to create an **Adaptive Icon**. WIth the support for themed icons from Android 13, you can use three images (background, foreground and monochrome) to create an **Adaptive Icon**. To use Adaptive Icons, you need to have installed at least version 9.0.0 of **Cordova** and version 8.0.0 of **Cordova-Android**.

Review Comment:
   Using a separate paragraph for Themed icons is way better, thank you! And thank you for adding the `v12.0.0` requirement.
   
   I think @erisu your suggestion is apt; unless there is anything else that you think I should consider, I think this is good to go. Kindly let me know.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org