You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2017/02/15 22:11:30 UTC

[1/2] isis git commit: ISIS-1561: fixes jira-release-notes.sh (seemingly broken, perhaps an upgrade of JIRA)

Repository: isis
Updated Branches:
  refs/heads/master 44ebd1217 -> 458d2fd95


ISIS-1561: fixes jira-release-notes.sh (seemingly broken, perhaps an upgrade of JIRA)


Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/9a3453d5
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/9a3453d5
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/9a3453d5

Branch: refs/heads/master
Commit: 9a3453d597b7653795fcadecf2b52313c8456068
Parents: 44ebd12
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Wed Feb 15 18:48:04 2017 +0000
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Wed Feb 15 18:48:04 2017 +0000

----------------------------------------------------------------------
 scripts/jira-release-notes.sh | 31 +++++++++++++++++++++++++------
 1 file changed, 25 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/isis/blob/9a3453d5/scripts/jira-release-notes.sh
----------------------------------------------------------------------
diff --git a/scripts/jira-release-notes.sh b/scripts/jira-release-notes.sh
index 0ab0251..275de95 100644
--- a/scripts/jira-release-notes.sh
+++ b/scripts/jira-release-notes.sh
@@ -64,9 +64,13 @@ function rawurlencode() {
 function jira_by_type () {
 
     type=$1
-    type_url_encoded=$( rawurlencode "$type" )
+    type_trimmed=$( echo "$type" | awk '{$1=$1};1' )
+    type_url_encoded=$( rawurlencode "$type_trimmed" )
     
     jira_url="https://issues.apache.org/jira/rest/api/2/search?jql=project%20in%20($project_upper)%20AND%20fixVersion%20in%20($version)%20AND%20type=\"$type_url_encoded\"&fields=summary"
+
+    #echo $jira_url
+
     jira_json=$(curl -s "$jira_url")
     if [ $? -ne 0 ]; then
         die "Failed to query JIRA for issue; url: $jira_url"
@@ -76,8 +80,16 @@ function jira_by_type () {
     #echo $jira_json | jq '.issues []  | { key: .key, summary: .fields .summary }'
 
     #so instead, let's do a cheap-n-nasty approach of creating two simple arrays of same length
-    keys=($(echo $jira_json | jq --raw-output '.issues []  | .key '))
-    echo $jira_json | jq --raw-output '.issues []  | .fields .summary ' > /tmp/$$.1
+    echo $jira_json | jq --raw-output '.issues []  | .key '             > /tmp/$$.keys
+    echo $jira_json | jq --raw-output '.issues []  | .fields .summary ' > /tmp/$$.summaries
+    
+    keys=()
+    i=0
+    while read line
+    do
+        keys[i]=$line
+        i=$(($i + 1))
+    done < /tmp/$$.keys
 
     summaries=()
     i=0
@@ -85,7 +97,7 @@ function jira_by_type () {
     do
         summaries[i]=$line
         i=$(($i + 1))
-    done < /tmp/$$.1
+    done < /tmp/$$.summaries
 
 
     echo
@@ -96,7 +108,9 @@ function jira_by_type () {
     total=${#keys[*]}
     for (( i=0; i<=$(( $total -1 )); i++ ))
     do
-        echo "* link:https://issues.apache.org/jira/browse/${keys[$i]}[${keys[$i]}] - ${summaries[$i]}"
+        key=$(echo "${keys[$i]}" | xargs )
+        summary="${summaries[$i]}"
+        echo "* link:https://issues.apache.org/jira/browse/$key[$key] - $summary"
     done
 
     
@@ -130,10 +144,13 @@ fi
 
 echo $jira_json | jq --raw-output '.issues []  | .fields .issuetype .name ' > /tmp/$$.1
 known_types=()
+
+
+
 i=0
 while read line
 do
-    known_types[i]=$line
+    known_types[i]=$(echo $line | awk '{$1=$1};1')
     i=$(($i + 1))
 done < /tmp/$$.1
 
@@ -152,6 +169,7 @@ for ordered_type in "${ordered_types[@]}"; do
         types+=("$ordered_type")
     fi
 done
+
 # for all $known_types that we haven't yet seen, add into $types
 for known_type in "${known_types[@]}"; do
     if [ $(contains "${types[@]}" "$known_type") == "n" ]; then 
@@ -160,6 +178,7 @@ for known_type in "${known_types[@]}"; do
 done
 
 
+
 #
 # Now generate the Asciidoc report
 #


[2/2] isis git commit: ISIS-1561: minor improvements to release docs

Posted by da...@apache.org.
ISIS-1561: minor improvements to release docs


Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/458d2fd9
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/458d2fd9
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/458d2fd9

Branch: refs/heads/master
Commit: 458d2fd953f9a8922df06e647f64115747b2d349
Parents: 9a3453d
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Wed Feb 15 22:11:13 2017 +0000
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Wed Feb 15 22:11:13 2017 +0000

----------------------------------------------------------------------
 .../guides/_cgcom_cutting-a-release.adoc        |  3 ---
 .../guides/_cgcom_release-process-prereqs.adoc  | 24 ++++++++++++--------
 2 files changed, 14 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/isis/blob/458d2fd9/adocs/documentation/src/main/asciidoc/guides/_cgcom_cutting-a-release.adoc
----------------------------------------------------------------------
diff --git a/adocs/documentation/src/main/asciidoc/guides/_cgcom_cutting-a-release.adoc b/adocs/documentation/src/main/asciidoc/guides/_cgcom_cutting-a-release.adoc
index 5fb8797..96e9e4d 100644
--- a/adocs/documentation/src/main/asciidoc/guides/_cgcom_cutting-a-release.adoc
+++ b/adocs/documentation/src/main/asciidoc/guides/_cgcom_cutting-a-release.adoc
@@ -447,8 +447,6 @@ mvn clean install
 [source,bash]
 ----
 mvn -pl webapp jetty:run
-<<<<<<< Updated upstream
-=======
 ----
 
 * can be packaged and run using the mvn jetty-console plugin:
@@ -457,7 +455,6 @@ mvn -pl webapp jetty:run
 ----
 mvn install -Dmavenmixin-jettyconsole
 mvn antrun:run -Dmavenmixin-jettyconsole
->>>>>>> Stashed changes
 ----
 
 * can be deployed as a WAR

http://git-wip-us.apache.org/repos/asf/isis/blob/458d2fd9/adocs/documentation/src/main/asciidoc/guides/_cgcom_release-process-prereqs.adoc
----------------------------------------------------------------------
diff --git a/adocs/documentation/src/main/asciidoc/guides/_cgcom_release-process-prereqs.adoc b/adocs/documentation/src/main/asciidoc/guides/_cgcom_release-process-prereqs.adoc
index 93dfb2c..200f098 100644
--- a/adocs/documentation/src/main/asciidoc/guides/_cgcom_release-process-prereqs.adoc
+++ b/adocs/documentation/src/main/asciidoc/guides/_cgcom_release-process-prereqs.adoc
@@ -13,23 +13,28 @@ This section (appendix) describes the prerequisites for the xref:cgcom.adoc#_cgc
 
 == Configure toolchains plugin
 
-Apache Isis releases are built using Java 7, enforced using the maven toolchains plugin.  Ensure that Java 7 is
-installed and the toolchains plugin is configured, as described in the
-xref:_dg_building-isis_configure-maven-toolchains-plugin[contributors' guide].
+Apache Isis releases are built using Java 7, enforced using the maven toolchains plugin.
+Ensure that Java 7 is installed and the toolchains plugin is configured, as described in the xref:_dg_building-isis_configure-maven-toolchains-plugin[contributors' guide].
 
 
 
 == Public/private key
 
-The most important configuration you require is to set up public/private key pair. This is used by the `maven-release-plugin` to sign the code artifacts. See the page on xref:cgcom.adoc#_cgcom_key-generation[key generation] for more details.
+The most important configuration you require is to set up public/private key pair.
+This is used by the `maven-release-plugin` to sign the code artifacts.
+See the page on xref:cgcom.adoc#_cgcom_key-generation[key generation] for more details.
 
 In order to prepare the release, you'll (need to) have a `~/.gnupg` directory with the relevant files (`gpg.conf`, `pubring.gpg`, `secring.gpg` etc), and have `gpg` on your operating system PATH.
 
 
 [NOTE]
 ====
-If on Windows, the equivalent directory is `c:\users\xxx\appdata\roaming\gnupg`. For `gpg`, use either http://cygwin.com[cygwin.com] or http://www.gpg4win.org[gpg4win.org]. Note also that the mSysGit version of `gpg` (as provided by GitHub's bash client) is not compatible with that provided by cygwin; move it to one side and check that `gpg.exe` being used is that from gpg4win.
+If on Windows, the equivalent directory is `c:\users\xxx\appdata\roaming\gnupg`.
+For `gpg`, use either http://cygwin.com[cygwin.com] or http://www.gpg4win.org[gpg4win.org].
 
+Note also that the mSysGit version of `gpg.exe` (as provided by GitHub's bash client) is not compatible with that provided by cygwin; move it to one side and check that `gpg.exe` being used is that from gpg4win.
+
+If you use Atlassian's SourceTree, this also bundles a version of `gpg.exe` that is not compatible (in `C:\Users\xxx\AppData\Local\Atlassian\SourceTree\git_local\usr\bin`); again, move it to one side and instead use the one provided by gpg4win.
 ====
 
 
@@ -53,12 +58,14 @@ During the release process the `maven-deploy-plugin` uploads the generated artif
 </settings>
 ----
 
-where `xxxxxxx` and `yyyyyyy` are your Apache LDAP username and password. For more information, see these http://www.apache.org/dev/publishing-maven-artifacts.html#dev-env[ASF docs].
+where `xxxxxxx` and `yyyyyyy` are your Apache LDAP username and password.
+For more information, see these http://www.apache.org/dev/publishing-maven-artifacts.html#dev-env[ASF docs].
 
 
 [NOTE]
 ====
-It is also possible to configure to use `.ssh` secure keys, and thereby avoid hardcoding your Apache LDAP password into your `.m2/settings.xml` file. A description of how to do this can be found, for example, http://bval.apache.org/release-setup.html[here].
+It is also possible to configure to use `.ssh` secure keys, and thereby avoid hardcoding your Apache LDAP password into your `.m2/settings.xml` file.
+A description of how to do this can be found, for example, http://bval.apache.org/release-setup.html[here].
 ====
 
 
@@ -83,6 +90,3 @@ Also, set up keyphrase for `gpg`; this avoids being prompted during release:
 </activeProfiles>
 ----
 
-
-
-