You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by ravikiran23 <gi...@git.apache.org> on 2016/09/12 05:45:41 UTC
[GitHub] incubator-carbondata pull request #149: wrong message getting displayed whil...
GitHub user ravikiran23 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/149
wrong message getting displayed while compaction.
Why raise this pr?
for each compaction the error message "compaction request file can not be deleted " is printing even though it has been deleted from the file system.
How to resolve?
The return of the boolean value is missing in the API deleteCompactionRequiredFile(). Need to return the boolean value correctly for getting the delete status.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravikiran23/incubator-carbondata WrongLogging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit 9ba6891f81abd1e5e807ee3adeb024bb94ca413f
Author: ravikiran <ra...@gmail.com>
Date: 2016-09-08T15:55:44Z
correcting wrong logs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #149: [CARBONDATA-234]wrong message gettin...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/149#discussion_r78782607
--- Diff: integration/spark/src/main/java/org/apache/carbondata/integration/spark/merger/CarbonCompactionUtil.java ---
@@ -210,10 +211,14 @@ public static boolean deleteCompactionRequiredFile(String metaFolderPath,
if (FileFactory.isFileExist(statusFile, FileFactory.getFileType(statusFile))) {
if (FileFactory.getCarbonFile(statusFile, FileFactory.getFileType(statusFile)).delete()) {
LOGGER.info("Deleted the compaction request file " + statusFile);
+ return true;
} else {
LOGGER.error("Unable to delete the compaction request file " + statusFile);
}
}
+ else {
--- End diff --
move one line up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #149: [CARBONDATA-234]wrong message gettin...
Posted by ravikiran23 <gi...@git.apache.org>.
Github user ravikiran23 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/149#discussion_r79223519
--- Diff: integration/spark/src/main/java/org/apache/carbondata/integration/spark/merger/CarbonCompactionUtil.java ---
@@ -210,9 +210,12 @@ public static boolean deleteCompactionRequiredFile(String metaFolderPath,
if (FileFactory.isFileExist(statusFile, FileFactory.getFileType(statusFile))) {
--- End diff --
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/225/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #149: [CARBONDATA-234]wrong message gettin...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/149#discussion_r79180388
--- Diff: integration/spark/src/main/java/org/apache/carbondata/integration/spark/merger/CarbonCompactionUtil.java ---
@@ -210,9 +210,12 @@ public static boolean deleteCompactionRequiredFile(String metaFolderPath,
if (FileFactory.isFileExist(statusFile, FileFactory.getFileType(statusFile))) {
--- End diff --
change statusFile to compactionRequestFile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #149: [CARBONDATA-234]wrong message gettin...
Posted by ravikiran23 <gi...@git.apache.org>.
Github user ravikiran23 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/149#discussion_r78961612
--- Diff: integration/spark/src/main/java/org/apache/carbondata/integration/spark/merger/CarbonCompactionUtil.java ---
@@ -210,10 +211,14 @@ public static boolean deleteCompactionRequiredFile(String metaFolderPath,
if (FileFactory.isFileExist(statusFile, FileFactory.getFileType(statusFile))) {
if (FileFactory.getCarbonFile(statusFile, FileFactory.getFileType(statusFile)).delete()) {
LOGGER.info("Deleted the compaction request file " + statusFile);
+ return true;
} else {
LOGGER.error("Unable to delete the compaction request file " + statusFile);
}
}
+ else {
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #149: [CARBONDATA-234]wrong message gettin...
Posted by ravikiran23 <gi...@git.apache.org>.
Github user ravikiran23 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/149#discussion_r79223488
--- Diff: integration/spark/src/main/java/org/apache/carbondata/integration/spark/merger/CarbonCompactionUtil.java ---
@@ -210,9 +210,12 @@ public static boolean deleteCompactionRequiredFile(String metaFolderPath,
if (FileFactory.isFileExist(statusFile, FileFactory.getFileType(statusFile))) {
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #149: [CARBONDATA-234]wrong message gettin...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/149#discussion_r78782633
--- Diff: integration/spark/src/main/java/org/apache/carbondata/integration/spark/merger/CarbonCompactionUtil.java ---
@@ -246,6 +251,9 @@ public static boolean createCompactionRequiredFile(String metaFolderPath,
return false;
}
}
+ else {
--- End diff --
move one line up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #149: [CARBONDATA-234]wrong message gettin...
Posted by ravikiran23 <gi...@git.apache.org>.
Github user ravikiran23 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/149#discussion_r78961659
--- Diff: integration/spark/src/main/java/org/apache/carbondata/integration/spark/merger/CarbonCompactionUtil.java ---
@@ -246,6 +251,9 @@ public static boolean createCompactionRequiredFile(String metaFolderPath,
return false;
}
}
+ else {
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #149: [CARBONDATA-234]wrong message gettin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---