[GitHub] wu-sheng commented on a change in pull request #871: Add elasticSearch-http storage module.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #871: Add elasticSearch-http storage module.
URL: https://github.com/apache/incubator-skywalking/pull/871#discussion_r178718213
 
 

 ##########
 File path: apm-collector/apm-collector-boot/src/main/resources/application.yml
 ##########
 @@ -34,18 +34,27 @@ ui:
     host: localhost
     port: 12800
     context_path: /
-storage:
-  elasticsearch:
-    cluster_name: CollectorDBCluster
-    cluster_transport_sniffer: true
-    cluster_nodes: localhost:9300
-    index_shards_number: 2
-    index_replicas_number: 0
-    ttl: 7
 #storage:
-#  h2:
-#    url: jdbc:h2:tcp://localhost/~/test
-#    user_name: sa
+#  elasticsearch:
+#    cluster_name: elasticsearch
+#    cluster_transport_sniffer: true
+#    cluster_nodes: 10.126.94.37:9300
+#    index_shards_number: 2
+#    index_replicas_number: 0
+#    ttl: 7
+#storage:
+#  elasticsearch-http:
 
 Review comment:
   Setting about this should not stay in documents. Please add this as a part of `Advanced Features` at here: https://github.com/apache/incubator-skywalking/blob/master/docs/README.md  
   
   English document is required, Chinese is optional for now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services