[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder

[GitBox <gi...@apache.org>]

Ted-Jiang commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922647109


##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -589,6 +680,38 @@ impl ByteArrayDecoderDictionary {
         }
         Ok(values_read)
     }
+
+    fn skip<I: OffsetSizeTrait + ScalarValue>(
+        &mut self,
+        dict: &OffsetBuffer<I>,
+        to_skip: usize,
+    ) -> Result<usize> {
+        let to_skip = to_skip.min(self.max_remaining_values);
+        // All data must be NULL
+        if dict.is_empty() {
+            return Ok(0);
+        }
+
+        let mut values_skip = 0;
+        while values_skip < to_skip {
+            if self.index_offset == self.index_buf_len {
+                let read = self.decoder.get_batch(self.index_buf.as_mut())?;

Review Comment:
   Agree! file an issue #2088



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org