[GitHub] [camel-k] tadayosi commented on a diff in pull request #3330: Adding basic support for `PodSecurityContext`.

[GitBox <gi...@apache.org>]

tadayosi commented on code in PR #3330:
URL: https://github.com/apache/camel-k/pull/3330#discussion_r888590837


##########
e2e/common/traits/pod_test.go:
##########
@@ -58,6 +58,30 @@ func TestPodTrait(t *testing.T) {
 	})
 }
 
+func TestPodTraitWithSupplementalGroups(t *testing.T) {

Review Comment:
   This pull req is great, but let's not add new `TestPod...` test function to add a test scenario to the pod trait testing. We prefer to add `t.Run("xxx", ...)` to add it to the existing `TestPodTrait()` to avoid create and destroy namespaces frequently for the e2e testing.
   https://github.com/apache/camel-k/issues/3298



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org