You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/09 10:31:50 UTC
[GitHub] [bookkeeper] zymap opened a new pull request, #3324: Apply the backpressure changes on the V2 requests
zymap opened a new pull request, #3324:
URL: https://github.com/apache/bookkeeper/pull/3324
---
*Motivation*
If one bookie is slow (not down, just slow), the BK client
will the acks to the user that the entries are written after
the first 2 acks. In the meantime, it will keep waiting for
the 3rd bookie to respond. If the bookie responds within the
timeout, the entries can now be dropped from memory, otherwise
the write will timeout internally and it will get replayed
to a new bookie.
In the V3 request, we have [server-side backpressure](https://github.com/apache/bookkeeper/pull/1410)
to impact the client-side behaviors. We should apply the same
changes to the V2 request. That would help this [issue](https://github.com/apache/pulsar/issues/14861)
to be resolved.
*Modification*
- Apply the change https://github.com/apache/bookkeeper/pull/1410 to V2 protocol
Descriptions of the changes in this PR:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
zymap commented on PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324#issuecomment-1156076423
@eolivelli @merlimat Please help to take a review when you have time.
Once the backpressure applies to the v2 requests, this will help to control the client's memory usage. Also can help to resolve the issue I mentioned in this [issue](https://github.com/apache/pulsar/issues/14861)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
zymap commented on PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324#issuecomment-1157131501
Thank you!
I have cherry-picked this PR to branch-4.14 and branch-4.15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324#issuecomment-1151756895
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324#issuecomment-1151786591
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324#issuecomment-1153201829
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324#issuecomment-1153106868
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
zymap commented on PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324#issuecomment-1150957095
As we mentioned in this [issue](https://github.com/apache/pulsar/issues/14861), broker is easy to OOM when there has one bookie slow.
After this change and applying the client-side configuration `waitTimeoutOnBackpressureMs=50`, the OOM issue looks resolved.
Broker Direct Memory:
Bookie Add latency:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
zymap commented on PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324#issuecomment-1151820197
The test `testBookieContinueWritingIfMultipleLedgersPresent` is failed and I am looking into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj merged pull request #3324: Apply the backpressure changes on the V2 requests
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #3324:
URL: https://github.com/apache/bookkeeper/pull/3324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org