[GitHub] [hive] viirya commented on a change in pull request #1792: HIVE-24551: Hive should include transitive dependencies from calcite after shading it

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #1792:
URL: https://github.com/apache/hive/pull/1792#discussion_r544772225



##########
File path: ql/pom.xml
##########
@@ -880,6 +880,12 @@
                   <include>joda-time:joda-time</include>
                   <include>org.apache.calcite:*</include>
                   <include>org.apache.calcite.avatica:avatica</include>
+                  <!-- include all of calcite's transitive dependencies as well since
+                    otherwise they'll be removed in assembly packaging -->
+                  <include>net.hydromatic:eigenbase-properties</include>
+                  <include>org.codehaus.janino:janino</include>
+                  <include>org.codehaus.janino:commons-compiler</include>
+                  <include>org.pentaho:pentaho-aggdesigner-algorithm</include>

Review comment:
       One question. Will this be flaky? Once calcite changes transitive dependencies, seems we also need to update this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org