You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/22 21:29:11 UTC

[GitHub] [superset] benjreinhart commented on pull request #13735: fix(#13734): Properly escape special characters in CSV output

benjreinhart commented on pull request #13735:
URL: https://github.com/apache/superset/pull/13735#issuecomment-804408081


   As an aside, the `CsvResponse` object is used in three places. In two of those, the mime type is set to `application/csv`, but I believe the expected csv mime type is `text/csv`. Can I make that change in this PR or would that be considered a breaking API change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org