You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/01/17 21:44:59 UTC

[commons-digester] branch master updated (4c0abae -> e9bc5fa)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-digester.git.


    from 4c0abae  Update local name.
     new cb4cfb4  Ignore IML (IntelliJ) files.
     new e9bc5fa  Make private elements final where possible.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .gitignore                                                            | 1 +
 .../main/java/org/apache/commons/digester3/plugins/PluginRules.java   | 2 +-
 core/src/test/java/org/apache/commons/digester3/ErrorHandlerTest.java | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)


[commons-digester] 02/02: Make private elements final where possible.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-digester.git

commit e9bc5fa1c09d8b00fd1d474d8380d3aa781a0a4b
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jan 17 16:44:55 2021 -0500

    Make private elements final where possible.
---
 .../main/java/org/apache/commons/digester3/plugins/PluginRules.java   | 2 +-
 core/src/test/java/org/apache/commons/digester3/ErrorHandlerTest.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java b/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java
index fd0dadf..0a0c61e 100644
--- a/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java
+++ b/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java
@@ -62,7 +62,7 @@ public class PluginRules
     /**
      * The rules implementation that we are "enhancing" with plugins functionality, as per the Decorator pattern.
      */
-    private Rules decoratedRules;
+    private final Rules decoratedRules;
 
     /** Object which contains information about all known plugins. */
     private final PluginManager pluginManager;
diff --git a/core/src/test/java/org/apache/commons/digester3/ErrorHandlerTest.java b/core/src/test/java/org/apache/commons/digester3/ErrorHandlerTest.java
index 75a5d35..543d5f9 100644
--- a/core/src/test/java/org/apache/commons/digester3/ErrorHandlerTest.java
+++ b/core/src/test/java/org/apache/commons/digester3/ErrorHandlerTest.java
@@ -69,7 +69,7 @@ public class ErrorHandlerTest
 
         final ErrorHandler customErrorHandler = new ErrorHandler()
         {
-            Log log = LogFactory.getLog( this.getClass() );
+            final Log log = LogFactory.getLog( this.getClass() );
 
             @Override
             public void warning( final SAXParseException arg0 )
@@ -124,7 +124,7 @@ public class ErrorHandlerTest
 
         final ErrorHandler customErrorHandler = new ErrorHandler()
         {
-            Log log = LogFactory.getLog( this.getClass() );
+            final Log log = LogFactory.getLog( this.getClass() );
 
             @Override
             public void warning( final SAXParseException arg0 )


[commons-digester] 01/02: Ignore IML (IntelliJ) files.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-digester.git

commit cb4cfb4774980c28cea3cc3e846bff8e3f9b22b1
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jan 17 16:42:26 2021 -0500

    Ignore IML (IntelliJ) files.
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index d11829c..36cfef1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,4 @@
 .project
 .settings/
 target/
+*.iml
\ No newline at end of file