You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Andrew Or (JIRA)" <ji...@apache.org> on 2015/12/16 03:26:46 UTC

[jira] [Resolved] (SPARK-9886) Validate usages of Runtime.getRuntime.addShutdownHook

     [ https://issues.apache.org/jira/browse/SPARK-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Or resolved SPARK-9886.
------------------------------
          Resolution: Fixed
            Assignee:     (was: Apache Spark)
       Fix Version/s: 2.0.0
                      1.6.1
    Target Version/s: 1.6.1, 2.0.0

> Validate usages of Runtime.getRuntime.addShutdownHook
> -----------------------------------------------------
>
>                 Key: SPARK-9886
>                 URL: https://issues.apache.org/jira/browse/SPARK-9886
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>            Reporter: Michel Lemay
>            Priority: Minor
>             Fix For: 1.6.1, 2.0.0
>
>
> While refactoring calls to Utils.addShutdownHook to spark ShutdownHookManager in PR #8109, I've seen instances of calls to Runtime.getRuntime.addShutdownHook:
> org\apache\spark\deploy\ExternalShuffleService.scala:126
> org\apache\spark\deploy\mesos\MesosClusterDispatcher.scala:113
> org\apache\spark\storage\ExternalBlockStore.scala:181
> Comment from @vanzin:
> "From a quick look, it seems that at least the one in ExternalBlockStore should be changed; the other two seem to be separate processes (i.e. they are not part of a Spark application) so that's questionable. But I'd say leave it for a different change (maybe file a separate bug so it doesn't fall through the cracks)."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org