You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/06/28 05:28:18 UTC
[GitHub] [superset] john-bodley opened a new pull request, #24538: chore: Constrain selenium version
john-bodley opened a new pull request, #24538:
URL: https://github.com/apache/superset/pull/24538
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Per the [Selenium changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/py/CHANGES#L8), https://github.com/SeleniumHQ/selenium/pull/12030 was included in 4.10.0 which removed deprecated code including the `firefox_profile` option we currently use.
This PR places an upper bound on the `selenium` version to prevent errors of the form,
```
...
File "/superset/utils/webdriver.py", line 147, in create
return driver_class(**kwargs)
TypeError: __init__() got an unexpected keyword argument 'firefox_profile'
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
CI and verified that the error was absent in 4.9.0 and present in 4.10.0.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #24538: chore: Constrain selenium version
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #24538:
URL: https://github.com/apache/superset/pull/24538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24538: chore: Constrain selenium version
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24538:
URL: https://github.com/apache/superset/pull/24538#issuecomment-1610764217
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24538](https://app.codecov.io/gh/apache/superset/pull/24538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ce2c426) into [master](https://app.codecov.io/gh/apache/superset/commit/750113441cd0160ed53e918253a7256466028ac0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7501134) will **decrease** coverage by `10.86%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24538 +/- ##
===========================================
- Coverage 68.93% 58.07% -10.86%
===========================================
Files 1903 1903
Lines 74027 74027
Branches 8118 8118
===========================================
- Hits 51027 42992 -8035
- Misses 20889 28924 +8035
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.79% <ø> (?)` | |
| python | `60.59% <ø> (-22.59%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.65% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 301 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24538/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org