You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2013/02/26 05:10:43 UTC
[Bug 54611] New: Location header for dav_created not URI encoded
https://issues.apache.org/bugzilla/show_bug.cgi?id=54611
Bug ID: 54611
Summary: Location header for dav_created not URI encoded
Product: Apache httpd-2
Version: 2.4.3
Hardware: PC
OS: Mac OS X 10.4
Status: NEW
Severity: normal
Priority: P2
Component: mod_dav
Assignee: bugs@httpd.apache.org
Reporter: tjw@omnigroup.com
Classification: Unclassified
I'm not sure this is the right approach, but returning a non-encoded URI
certainly isn't. In particular, I wonder if the optimization of using
unparsed_uri is good or whether the r->uri should be escaped.
Again, diff is vs our local copy of 2.4.3.
-tim
Index: trunk/Apache/httpd/modules/dav/main/mod_dav.c
===================================================================
--- trunk/Apache/httpd/modules/dav/main/mod_dav.c (revision 180429)
+++ trunk/Apache/httpd/modules/dav/main/mod_dav.c (revision 180431)
@@ -611,7 +611,9 @@
const char *body;
if (locn == NULL) {
- locn = r->uri;
+ locn = r->unparsed_uri;
+ } else {
+ locn = ap_escape_uri(r->pool, locn);
}
/* did the target resource already exist? */
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54611] Location header for dav_created not URI encoded
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54611
--- Comment #1 from Timothy Wood <tj...@omnigroup.com> ---
A specific case of this may be
<https://issues.apache.org/bugzilla/show_bug.cgi?id=54367> but all
Location-returning commands have the issue.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54611] Location header for dav_created not URI encoded
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54611
--- Comment #3 from Graham Leggett <mi...@sharp.fm> ---
Applied to trunk in r1476621.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54611] Location header for dav_created not URI encoded
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54611
--- Comment #2 from Wim Lewis <wi...@omnigroup.com> ---
A quick test against trunk/2.5 r1470683 shows that the bug still exists there
and this patch still fixes it there.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54611] Location header for dav_created not URI encoded
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54611
--- Comment #4 from Graham Leggett <mi...@sharp.fm> ---
Proposed for backport to v2.4 and v2.2.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54611] Location header for dav_created not URI encoded
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54611
Wim Lewis <wi...@omnigroup.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |54367
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54611] Location header for dav_created not URI encoded
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54611
--- Comment #5 from Graham Leggett <mi...@sharp.fm> ---
Backported to v2.4.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org