You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/06/03 13:38:43 UTC

Review Request 34995: LENS-557 : Adds failure reason for FAILED queries in QueryStatusLogger logger.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34995/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-557
    https://issues.apache.org/jira/browse/LENS-557


Repository: lens


Description
-------

Added reason on the toString(). Also fixed newStatusChangeEvent to include reason for failure


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 4bf43d7 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java dbc52e9 

Diff: https://reviews.apache.org/r/34995/diff/


Testing
-------

The new log looks the following :

----
03 Jun 2015 16:37:18,431 [pool-5-thread-4] INFO  org.apache.lens.server.query.QueryExecutionServiceImpl$QueryStatusLogger 394  - QueryEvent: QueryFailed:{id: cb05ea68-bf40-4a85-b75e-fd9d75d1fb80, query:5c4683ac-38f3-40d0-b8f4-13e8ec65bbbb, change:[QUEUED -> FAILED]} cause:Launching query failed
 Reason:
 Driver :org.apache.lens.driver.hive.HiveDriver Cause :No candidate fact table available to answer the query, because {"brief":"Missing partitions for the cube table: [[it:[2014-12-01-00-00-00, 2014-12-02-00-00-00)]]","details":{"xxxxx}
----

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.193s]
[INFO] Lens .............................................. SUCCESS [3.538s]
[INFO] Lens API .......................................... SUCCESS [23.469s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.910s]
[INFO] Lens Cube ......................................... SUCCESS [3:39.117s]
[INFO] Lens DB storage ................................... SUCCESS [21.198s]
[INFO] Lens Query Library ................................ SUCCESS [19.198s]
[INFO] Lens Hive Driver .................................. SUCCESS [6:51.461s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [47.413s]
[INFO] Lens Server ....................................... SUCCESS [6:44.973s]
[INFO] Lens client ....................................... SUCCESS [40.598s]
[INFO] Lens CLI .......................................... SUCCESS [3:32.231s]
[INFO] Lens Examples ..................................... SUCCESS [9.419s]
[INFO] Lens Distribution ................................. SUCCESS [8.372s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:22.323s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.764s]
[INFO] Lens Regression ................................... SUCCESS [12.576s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:45.796s
[INFO] Finished at: Wed Jun 03 11:38:22 UTC 2015
[INFO] Final Memory: 169M/1465M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 34995: LENS-557 : Adds failure reason for FAILED queries in QueryStatusLogger logger.

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34995/#review87134
-----------------------------------------------------------

Ship it!


Ship It!

- Jaideep dhok


On June 3, 2015, 11:38 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34995/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 11:38 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-557
>     https://issues.apache.org/jira/browse/LENS-557
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added reason on the toString(). Also fixed newStatusChangeEvent to include reason for failure
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 4bf43d7 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java dbc52e9 
> 
> Diff: https://reviews.apache.org/r/34995/diff/
> 
> 
> Testing
> -------
> 
> The new log looks the following :
> 
> ----
> 03 Jun 2015 16:37:18,431 [pool-5-thread-4] INFO  org.apache.lens.server.query.QueryExecutionServiceImpl$QueryStatusLogger 394  - QueryEvent: QueryFailed:{id: cb05ea68-bf40-4a85-b75e-fd9d75d1fb80, query:5c4683ac-38f3-40d0-b8f4-13e8ec65bbbb, change:[QUEUED -> FAILED]} cause:Launching query failed
>  Reason:
>  Driver :org.apache.lens.driver.hive.HiveDriver Cause :No candidate fact table available to answer the query, because {"brief":"Missing partitions for the cube table: [[it:[2014-12-01-00-00-00, 2014-12-02-00-00-00)]]","details":{"xxxxx}
> ----
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.193s]
> [INFO] Lens .............................................. SUCCESS [3.538s]
> [INFO] Lens API .......................................... SUCCESS [23.469s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.910s]
> [INFO] Lens Cube ......................................... SUCCESS [3:39.117s]
> [INFO] Lens DB storage ................................... SUCCESS [21.198s]
> [INFO] Lens Query Library ................................ SUCCESS [19.198s]
> [INFO] Lens Hive Driver .................................. SUCCESS [6:51.461s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [47.413s]
> [INFO] Lens Server ....................................... SUCCESS [6:44.973s]
> [INFO] Lens client ....................................... SUCCESS [40.598s]
> [INFO] Lens CLI .......................................... SUCCESS [3:32.231s]
> [INFO] Lens Examples ..................................... SUCCESS [9.419s]
> [INFO] Lens Distribution ................................. SUCCESS [8.372s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:22.323s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.764s]
> [INFO] Lens Regression ................................... SUCCESS [12.576s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:45.796s
> [INFO] Finished at: Wed Jun 03 11:38:22 UTC 2015
> [INFO] Final Memory: 169M/1465M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>