[GitHub] [commons-collections] kinow commented on pull request #189: [COLLECTIONS-768] Fix flaky Flat3MapTest.testEntrySet()

[GitBox <gi...@apache.org>]

kinow commented on pull request #189:
URL: https://github.com/apache/commons-collections/pull/189#issuecomment-705865306


   Hi @tongxin97 
   
   >@kinow Thanks for taking a look. I'm under the impression that a regular LinkedHashMap or a TreeMap with custom comparator could preserve insertion order.
   
   If so maybe this test could be fixed by changing the data structure given to the method you changed? e.g.
   
   ```java
       public void testEntrySet() {
           // Sanity check
           putAndRemove(new TreeMap<>());
           // Actual test
           putAndRemove(new Flat3Map<>(new TreeMap<>()));
       }
   ```
   
   (I tried to reproduce the failure locally, but it didn't happen after I tried ~10 times, so not 100% if that fixes it, just a quick code to show what I meant)
   
   >Btw I'm new to contributing to Apache projects, so for logistics, are you (or someone else from your team) going to accept and merge this PR? Is there anything more you need from my side?
   
   You are doing really great! If I were confident in the change, I could merge it. Developers may leave pull requests approved without merging too. It depends on how confident a developer is to merge the change. Here, I am hoping another developer (maybe someone more familiar with Commons Collections) will take a look and chime-in with his/her point of view.
   
   If another developer thinks this is a good fix, I'd be OK with this being merged. So you don't need to change anything for now, unless you have some other ideas on how to fix the issue :+1: 
   
   Thanks!
   Bruno


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org