You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/15 23:32:18 UTC

[GitHub] abellina opened a new pull request #23806: SPARK-26895: prepareSubmitEnvironment should be called within doAs fo…

abellina opened a new pull request #23806: SPARK-26895: prepareSubmitEnvironment should be called within doAs fo…
URL: https://github.com/apache/spark/pull/23806
 
 
   …r proxy users
   
   ## What changes were proposed in this pull request?
   
   `prepareSubmitEnvironment` performs globbing that will fail in the case where a proxy user (--proxy-user) doesn't have permission to the file. This is a bug also with 2.3, so we should backport, as currently you can't launch an application that for instance is passing a file under --archives, and that file is owned by the target user.
   
   The solution is to call `prepareSubmitEnvironment` within a doAs context if proxying.
   
   ## How was this patch tested?
   
   Manual tests running with --proxy-user and --archives, before and after, showing that the globbing logic wouldn't fail in this case.
   
   I can try to write a unit test if needed.
   
   Please review http://spark.apache.org/contributing.html before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org