You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/01 21:54:14 UTC

Re: Review Request 68091: Always build gRPC in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68091/
-----------------------------------------------------------

(Updated Aug. 1, 2018, 9:54 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Rebased.


Bugs: MESOS-8395
    https://issues.apache.org/jira/browse/MESOS-8395


Repository: mesos


Description
-------

Always build gRPC in libprocess.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am da350b1d36b9f545372999f38acc5022a9ca1034 
  3rdparty/libprocess/Makefile.am abf667373aa65c9bb196d05a48d5d826d4d375e2 
  3rdparty/libprocess/configure.ac f125e43800bcb6477b3c2ea5802040fa38411565 
  3rdparty/libprocess/src/CMakeLists.txt bb8af6d09d4d5207c7eb75c32bbd2952fd4e75a6 
  3rdparty/libprocess/src/tests/CMakeLists.txt 5814bc615a8bf164ab563d9c32860f7d4e9325e0 


Diff: https://reviews.apache.org/r/68091/diff/2/

Changes: https://reviews.apache.org/r/68091/diff/1-2/


Testing
-------

`sudo make check` for standalone libprocess build.

NOTE: Mesos will fail to build if gRPC is not enabled.


Thanks,

Chun-Hung Hsiao