You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/07 21:28:08 UTC

[GitHub] [incubator-nuttx] btashton opened a new pull request #2241: Fix issue #2098 non functional sim:touchscreen

btashton opened a new pull request #2241:
URL: https://github.com/apache/incubator-nuttx/pull/2241


   ## Summary
   This resolves three issues with sim:touchscreen that made it non-functional as noted in #2098 
   1. sim_bringup() was never called because CONFIG_BOARD_LATE_INITIALIZE was not enabled and the touchscreen example does not use  the boadctl to trigger it.
   2. `NX_MXSVRMSGLEN` `NX_MXEVENTLEN` `NX_MXCLIMSGLEN` are all defined as 64, but the default CONFIG_MQ_MAXMSGSIZE is only 32 which would cause an assertion.
   3. `CONFIG_NX_BLOCKING` was not enabled which causes `sim_listener` to be in a tight loop and the idle loop that serves the events is never triggered.  This is warned in the function.
   
   ## Impact
   The sim:touchscreen configuration now works.
   
   ## Testing
   Manual testing on Linux.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2241: Fix issue #2098 non functional sim:touchscreen

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2241:
URL: https://github.com/apache/incubator-nuttx/pull/2241#issuecomment-723506267


   This is now two commits where the second one deals with the new split with the SIM_LCDDRIVER vs SIM_FRAMEBUFER.  When this is backported only the first commit should be picked up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2241: Fix issue #2098 non functional sim:touchscreen

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2241:
URL: https://github.com/apache/incubator-nuttx/pull/2241


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org