You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/28 07:27:44 UTC

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #7759: Add wait logic to ensure no data lost when remove a Peer from MultiLeader consensus group

SpriCoder commented on code in PR #7759:
URL: https://github.com/apache/iotdb/pull/7759#discussion_r1007741509


##########
consensus/src/main/java/org/apache/iotdb/consensus/multileader/MultiLeaderServerImpl.java:
##########
@@ -479,6 +481,45 @@ public void notifyPeersToRemoveSyncLogChannel(Peer targetPeer)
     }
   }
 
+  public void waitTargetPeerUntilSyncLogCompleted(Peer targetPeer)
+      throws ConsensusGroupAddPeerException {
+    long checkIntervalInMs = 10_000L;

Review Comment:
   Maybe this value can be a property of MultiLeaderConfig



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org