[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

[GitBox <gi...@apache.org>]

pdxcodemonkey commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r453764965



##########
File path: cppcache/src/ExceptionTypes.cpp
##########
@@ -297,7 +297,25 @@ const std::string& getThreadLocalExceptionMessage();
       PutAllPartialResultException ex(message);
       throw ex;
     }
-    default: {
+    case GF_NOERR:

Review comment:
       Same as above - adding a zillion case statements doesn't make code clearer.

##########
File path: cppcache/include/geode/DataInput.hpp
##########
@@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput {
         // empty string
         break;
       // TODO: What's the right response here?
-      default:
+      case internal::DSCode::FixedIDDefault:

Review comment:
       Wow I really really don't like this.  Is there anything we can do to fix the warning _besides_ adding ~65 case statements?  This makes the code less readable, not more IMO.

##########
File path: cppcache/src/TcrMessage.cpp
##########
@@ -1015,6 +1015,36 @@ void TcrMessage::processChunk(const std::vector<uint8_t>& chunk, int32_t len,
         break;
       }
       // fall-through for other cases
+      if (m_chunkedResult != nullptr) {

Review comment:
       What's this block of code doing?  I don't immediately see a place where it was removed/moved, so is it new?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org