You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/02 07:52:53 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #476: add random and now function
Jimexist opened a new pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #476: add random and now function
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476#issuecomment-853482812
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#476](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea90a2f) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/33ff660318bf60d0c9aa45ceba2c4c943bfe9438?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33ff660) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 153 153
Lines 25924 25924
=======================================
Hits 19652 19652
Misses 6272 6272
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33ff660...ea90a2f](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on a change in pull request #476: add random and now function
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476#discussion_r643833941
##########
File path: python/src/functions.rs
##########
@@ -149,13 +157,27 @@ fn md5(value: expression::Expression) -> expression::Expression {
}
}
+#[pyfunction]
+fn now(value: expression::Expression) -> expression::Expression {
+ expression::Expression {
+ expr: logical_plan::now(value.expr),
Review comment:
Do you know why the logical `now` has one argument? I though that the physical one had the `NullArray`, but that in the logical plane, the function would be zero-argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist closed pull request #476: add random and now function
Posted by GitBox <gi...@apache.org>.
Jimexist closed pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #476: add random and now function
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476#issuecomment-853482812
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#476](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea90a2f) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/33ff660318bf60d0c9aa45ceba2c4c943bfe9438?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33ff660) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 153 153
Lines 25924 25924
=======================================
Hits 19652 19652
Misses 6272 6272
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33ff660...ea90a2f](https://codecov.io/gh/apache/arrow-datafusion/pull/476?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #476: python: add random and now function
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476#issuecomment-852996481
error is likely not relevant, merge after fix in #468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #476: add random and now function
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476#discussion_r643910304
##########
File path: python/src/functions.rs
##########
@@ -149,13 +157,27 @@ fn md5(value: expression::Expression) -> expression::Expression {
}
}
+#[pyfunction]
+fn now(value: expression::Expression) -> expression::Expression {
+ expression::Expression {
+ expr: logical_plan::now(value.expr),
Review comment:
maybe because they all take one arg which is the `&[Arg]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist closed pull request #476: add random and now function
Posted by GitBox <gi...@apache.org>.
Jimexist closed pull request #476:
URL: https://github.com/apache/arrow-datafusion/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org