Re: [PATCH] Allow export to export svn:eol-style=native files with a user suplied eol marker.

[Ben Reser <be...@reser.org>]

Patch committed in r9719 with changes based upon the comments.

On Sun, Apr 04, 2004 at 11:31:01PM +0100, Philip Martin wrote:
> > Hm.  That erroneously accepts "native", but I guess that's no big deal
> > if the command-line client is filtering for that.
> 
> I already suggested that we allow "native" for consistency ;)  If we
> did that we drop the literal check in main.c and simply use the result
> of svn_subst_eol_style_from_value to determine whether to raise an
> error.

Done.  But I left the filtering in the client.  It takes a long time to
raise the error if you don't.

> > Also, we don't document that NULL is an acceptable first argument to
> > svn_subst_eol_style_from_value.  We should fix the documentation before
> > adding any (more) call sites which rely on that bit of defensiveness.
> 
> Or just pass &dummy instead of NULL, none of the other callers pass
> NULL.  I didn't read the docs, I just came across the function when
> grepping for literals like "CR" etc.

Actually the style value is needed to decide on the error to return. :)

-- 
Ben Reser <be...@reser.org>
http://ben.reser.org

"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org