You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/10/12 19:10:29 UTC
[kudu-CR] [test] ASSERT OK instead of CHECK OK when appropriate
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19134
Change subject: [test] ASSERT_OK instead of CHECK_OK when appropriate
......................................................................
[test] ASSERT_OK instead of CHECK_OK when appropriate
Recently I ran a few tests in FIPS environment, and even if those were
expected to fail because our test scenarios use very short encryption
keys to run faster (compared with minimum allowed encryption key size
required by FIPS 140-2), I was unpleasantly surprised that some of those
simply crashed instead of exiting gracefully and reporting an error.
This patch addresses that for rpc-test and tls_socket-test.
Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a
---
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/tls_socket-test.cc
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/19134/1
--
To view, visit http://gerrit.cloudera.org:8080/19134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a
Gerrit-Change-Number: 19134
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [test] ASSERT OK instead of CHECK OK when appropriate
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19134 )
Change subject: [test] ASSERT_OK instead of CHECK_OK when appropriate
......................................................................
[test] ASSERT_OK instead of CHECK_OK when appropriate
Recently I ran a few tests in FIPS environment, and even if those were
expected to fail because our test scenarios use very short encryption
keys to run faster (compared with minimum allowed encryption key size
required by FIPS 140-2), I was unpleasantly surprised that some of those
simply crashed instead of exiting gracefully and reporting an error.
This patch addresses that for rpc-test and tls_socket-test.
Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a
Reviewed-on: http://gerrit.cloudera.org:8080/19134
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/tls_socket-test.cc
2 files changed, 12 insertions(+), 6 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a
Gerrit-Change-Number: 19134
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] ASSERT OK instead of CHECK OK when appropriate
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19134
to look at the new patch set (#2).
Change subject: [test] ASSERT_OK instead of CHECK_OK when appropriate
......................................................................
[test] ASSERT_OK instead of CHECK_OK when appropriate
Recently I ran a few tests in FIPS environment, and even if those were
expected to fail because our test scenarios use very short encryption
keys to run faster (compared with minimum allowed encryption key size
required by FIPS 140-2), I was unpleasantly surprised that some of those
simply crashed instead of exiting gracefully and reporting an error.
This patch addresses that for rpc-test and tls_socket-test.
Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a
---
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/tls_socket-test.cc
2 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/19134/2
--
To view, visit http://gerrit.cloudera.org:8080/19134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a
Gerrit-Change-Number: 19134
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] ASSERT OK instead of CHECK OK when appropriate
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19134 )
Change subject: [test] ASSERT_OK instead of CHECK_OK when appropriate
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a
Gerrit-Change-Number: 19134
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Oct 2022 19:16:06 +0000
Gerrit-HasComments: No
[kudu-CR] [test] ASSERT OK instead of CHECK OK when appropriate
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19134 )
Change subject: [test] ASSERT_OK instead of CHECK_OK when appropriate
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48d9bb2def2350c11afc41b9f08fa252c7ead65a
Gerrit-Change-Number: 19134
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Oct 2022 20:33:45 +0000
Gerrit-HasComments: No