You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/25 20:04:30 UTC

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6165: SAML: replace first number with random alphabet if request ID starts with a number

weizhouapache commented on a change in pull request #6165:
URL: https://github.com/apache/cloudstack/pull/6165#discussion_r835576944



##########
File path: plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
##########
@@ -100,8 +100,11 @@
 public class SAMLUtils {
     public static final Logger s_logger = Logger.getLogger(SAMLUtils.class);
 
+    static final String charset = "abcdefghijklmnopqrstuvwxyz";

Review comment:
       @rohityadavcloud 
   I have checked hundreds of request IDs, all are composed by digits (0 to 9) or lower case alphabet (a to z).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org