[GitHub] [daffodil] mbeckerle commented on a diff in pull request #898: Add emptyElementParsePolicy to main DFDL namespace.

[GitBox <gi...@apache.org>]

mbeckerle commented on code in PR #898:
URL: https://github.com/apache/daffodil/pull/898#discussion_r1054483173


##########
daffodil-test/src/test/resources/org/apache/daffodil/usertests/SepTests.tdml:
##########
@@ -194,11 +194,7 @@
       representation="text"
       lengthKind="delimited"
       separatorPosition="infix"
-      dfdlx:emptyElementParsePolicy="treatAsEmpty"/><!-- remove extension proerty for IBM cross tests -->
-    <!--
-    Note: dfdlx:emptyElementParsePolicy should become regular DFDL emptyElementParsePolicy
-    once implemented in DAFFODIL-2496. The enum 'treatAsMissing' is renamed to 'treatAsAbsent'
-    -->
+      emptyElementParsePolicy="treatAsEmpty"/><!-- remove extension property for IBM cross tests -->

Review Comment:
   The property dfdl:emptyElementParsePolicy value 'treatAsEmpty' is an optional feature of DFDL.
   IBM does not support 'treatAsEmpty' behavior, only 'treatAsAbsent'.
   
   As for whether they added this property, let's test it. We have the IBM DFDL Cross tester.  https://github.com/OpenDFDL/ibmDFDLCrossTester



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org